Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Trample Crops vs Trample Farmland #3

Closed
Unleashed75 opened this issue Jul 23, 2024 · 2 comments · Fixed by #5
Closed

[Feature]: Trample Crops vs Trample Farmland #3

Unleashed75 opened this issue Jul 23, 2024 · 2 comments · Fixed by #5
Labels
approved New feature to be implemented.

Comments

@Unleashed75
Copy link

Request Description

I would like to see the Trample Crops rule only work on farmland that has crops on them.

The current Trample Crops rule stops trampling farmland, regardless of crops being on top of it or not.
If the farmland has no crops on it, I would need to place blocks on top and break them, or remove water source but this may not be easy if the farmland is by a river etc.
This acts more like a Trample Farmland rule.

A true Trample Crops rule would be only when farmland has no crops on top, can it be trampled.
This means if I placed farmland and crops in the wrong spot, I just have to remove the crop and jump on the farmland a couple times.

Maybe have the option for both, or rename to suit what it really does?

Great mod either way. Thank you!

Images

No response

Fabric Version

No response

Additional Context

No response

@BVengo
Copy link
Owner

BVengo commented Aug 11, 2024

Great addition! I wasn't sure if anyone would want this split, but I should definitely be able to turn this into two configs instead.

@BVengo BVengo added the approved New feature to be implemented. label Aug 11, 2024
@BVengo
Copy link
Owner

BVengo commented Aug 29, 2024

Making a note of my current dev implementation before it makes it into a release. This issue will be closed when I commit the changes to the main branch, however feel free to comment further if you would like to propose a different solution.

  • TRAMPLE_FARMLAND: Can the entity turn farmland into dirt?
  • TRAMPLE_CROPS: Can the entity kill crops?

I'll refer to these as F (TRAMPLE_FARMLAND) and C (TRAMPLE_CROPS) for the below.

So, the possible combinations are:

  • FC: Normal behaviour, since destruction of farmland and crops are both allowed. Trampling farmland will turn it into dirt and the crops will be dropped.
  • F: Cannot destroy crops. Will only turn farmland into dirt if it has no crops above it.
  • C: Cannot destroy farmland. Will still destroy crops when farmland is (normally) supposed to be turned into dirt.

BVengo added a commit that referenced this issue Aug 30, 2024
@BVengo BVengo closed this as completed Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved New feature to be implemented.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants