Development sync ahead of Nov course #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edit probe class
quick fix on negative value check
Function to include zero values.
* -- Move DataTree and some Utils functions to independent submodules used by AtlasViewer and Homer3 * Add config file to DataTree and ability to load mutiple config files to config utility Add config file to DataTree and ability to load mutiple config files to config utility
…th setpaths. Needed to disable git certificate verification when executing 'git submodule update' from matlab
…ing git installed.
…t is run. Add option to 'update' submodules to get latest changes.
…es setpaths to hang waiting for user to press ENTER because the system command running 'git branch' executes in its own shell. Setting the TERM=ansi seems to fix this issue.
… for user input on MAC. Need to parse and remove garbage output correctly too
…igm of submodules and parent repo being one code (#78) -- Fix submodule download in setpaths without git not working because setpaths options are not parsed correctly. -- Clean up and remove obsolete files
… the non-git method. Assumtion that Github creates empty folder as placeholders for submodules when downloading using the "Download ZIP" option is not always true. Sometimes it creates empty folder, somtimes it doesn't. So isemptyFolder doesn't work when folder is not created. Added code to create empty submodule folder placeholder when it is missing. -- Clean up: remove more obsolete files
…es download because of a previous error then need to clean uo submodule folders so there's no garbage in there then retry downloading.
-- Add .numberfiles to submodules and check during setpaths process to make sure an incomplete download is detected and triggers a clean download.
…, '*.m']) works differently on those platform than on Windows when there are NO files matching the specified pattern. Use dir instead of ls to fix this. -- Fix multiple issues in submodule downloading using non-git method. -- When user click cancel in response to download fail dialog, quit rather than retry. -- Add search paths ONLY for the submodules that were successfully installed -- Fix typos in dialog failed download message
…ause the delimiter for path string is ':' not ';' as it is on Winodws. b) On linux the gitSetBranch.m used to get latest branch revis
-- Fix issue in setpaths with non-git submodule download and install. a) Fix some bugs and typos preventing correct download. b) Clean up and delete downloaded submodules files which are no longer needed after installation like the zip file and initial unzipped folder c) Clarify input dialog message and try to guess and or suggest the correct branch that matches parent repo -- Add exception handling to setpaths. in case of error return to original folder -- Add comprehensive help comments to setpaths describing it's use
…lready has been added to search paths
- GLM docs fixes - Convolve HRFs with stim duration before export
…ith unexpected matlab behavior because of inclusion of weird .m files from a build of AV. So for instance exclude *.app and *_install folders which contain a large amount of files which should never be included in matlab search paths. -- Add ability to findDotMFolders to exclude folders based on wildcard patterns rather than only explicit names. This allows exclusion of many folders that fit a pattern without having to explicitly list ALL of them -- Fix several bugs in the build for MAC -- Finally fixed the requirement that you have to run MAC installation specifically from ~/Downloads/homer3_install. Added code to makesetup.pl to create a more intelligent setup.command which does not depend on execution from a specific folder.
…tallation folder -- Improve launch performance by changing config file access to global variable
…s about which branch to download. Instead derive the branch name from root folder name of parent app and default to master of it cannot be determined. This change somehow did not make it earlier into repo
…/closing ConfigFileClass objects -- Update getVernum to match AV -- Update submodule references
-- Update DataTree submodule reference to latest change containing fix for errors when there are no data files (because all have errors that prevent loading) -- Fix more issues with install executable on MAC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.