Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AddressCompat to display address #67

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Use AddressCompat to display address #67

merged 1 commit into from
Jan 18, 2023

Conversation

crisdut
Copy link
Member

@crisdut crisdut commented Jan 6, 2023 •
edited
Loading

Closes #65

dr-orlovsky
dr-orlovsky requested changes Jan 17, 2023
View reviewed changes
descriptors/src/derive.rs Outdated Show resolved Hide resolved
descriptors/src/derive.rs Outdated Show resolved Hide resolved
@crisdut crisdut force-pushed the fix/address-compat branch from 8fca9d0 to 72e3378 Compare January 17, 2023 19:26
@crisdut crisdut requested a review from dr-orlovsky January 17, 2023 19:26
@crisdut crisdut force-pushed the fix/address-compat branch from 72e3378 to c134543 Compare January 17, 2023 19:36
dr-orlovsky
dr-orlovsky approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c134543

@dr-orlovsky dr-orlovsky merged commit 67113c7 into BP-WG:master Jan 18, 2023
@dr-orlovsky dr-orlovsky added this to the v0.9.0 milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-orlovsky dr-orlovsky dr-orlovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

Use AddressCompat instead of rust-bitcoin Address to display address
2 participants
@crisdut @dr-orlovsky