Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nightly build, lint and manifest for wasm-testing #53

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

zoedberg
Copy link
Contributor

This PR fixes the build on nightly. @dr-orlovsky I have used 0.11 beta 9 as base for the commit and would be glad if you could release a beta 9.1 for this (it would fix the new CI job added in RGB-WG/rgb-tests#25)

@zoedberg zoedberg requested a review from dr-orlovsky November 25, 2024 16:17
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.6%. Comparing base (9fedc14) to head (78e8416).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
derive/src/xkey.rs 0.0% 1 Missing ⚠️
psbt/src/data.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master     #53   +/-   ##
======================================
  Coverage    42.6%   42.6%           
======================================
  Files          24      24           
  Lines        4235    4235           
======================================
  Hits         1804    1804           
  Misses       2431    2431           
Flag Coverage Δ
rust 42.6% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoedberg zoedberg changed the title fix nightly build fix nightly build, lint and manifest for wasm-testing Dec 2, 2024
Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 78e8416

@dr-orlovsky dr-orlovsky merged commit 0dd57b9 into BP-WG:master Dec 17, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants