-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specifying an exact version of cc in Cargo.toml causes collisions when using other crates #83
Comments
Note that in Cargo.toml, |
Oh, that's cool :) |
Sorry for the partial answer above :) I think the answer is yes, we could lower the version of |
Ah here's some more detail about my first question. Apparently Cargo only allows multiple versions of a crate if the two versions in question aren't semver-compatible with each other: rust-lang/cargo#6584 (comment) |
To be fair, from this crate's perspective there's nothing that needs to be done, since even if you set your minimum version really low, cargo will still always fetch the newest version it can. That way even if it's not actually supported, you won't see an issue with CI. I think that's a wider issue that I'm not sure how to handle. This is only a problem because of compatibility with other crates that have stricter supported versions. You sent the above as i was writing that i have no ides why the collision was happening, thanks for finding that out, i didn't know about that :D |
I've tested manually and found that 1.0.4 is the oldest version of `cc` that builds successfully for us. (Version 1.0.3 is missing the `is_flag_supported` method.) This change might help with #83. That said, the underlying issue there is related to "minimum supported Rust versions", and `blake3` does not yet have an MSRV other than latest stable.
I've just pushed the commit above, which lowers our required version of There's no downside to making this change, like you said, so I'm happy to do it if it solves the problem. But I also want to be clear that |
Thankfully, my project does not have a minimum supported compiler version either, and we're using recent nightlies for all our builds :) We also don't mind using github dependencies (and are forced to with some dependencies) so there's no need for an urgent release :) The issue as far as we're concerned is Thank you for the rapid response and fix! 😄 |
Very welcome, always happy to have real world users :) I'll close this for now, but feel free to reopen it if something breaks. |
The
blake3
crate requires using exactly version1.0.48
of thecc
crate. This causes conflicts when trying to use it with packages that require different versions ofcc
, such assecp256k1
(because of this issue).Is this an intentional limitation, or can the dependency be loosened to any of the
1.*
versions ofcc
? (even setting a minimum version of1.0.41
or lower will be acceptable for this use-case)The text was updated successfully, but these errors were encountered: