Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have cropps ONLY handle images that are in one of the upload directories #13

Closed
weotch opened this issue Feb 21, 2013 · 5 comments
Closed

Have cropps ONLY handle images that are in one of the upload directories #13

weotch opened this issue Feb 21, 2013 · 5 comments
Labels
bug

Comments

@weotch
Copy link
Member

weotch commented Feb 21, 2013

Check out this exception:

https://bkwld.codebasehq.com/projects/mcdonalds-goodmorningstl/exceptions/33bca9b0-2a4d-5031-0ed3-ec645227e658

This route was triggering croppa: http://goodmorningstl.com/apple-touch-icon-72x72-precomposed.png
@weotch
Copy link
Member Author

weotch commented Sep 8, 2013

Huh, the problem is that we don't actually store upload directories in the config file now. It's the public_path().

@weotch
Copy link
Member Author

weotch commented Sep 8, 2013

Do I add a new config option, then, that adds a condition to the pattern filter?

weotch added a commit that referenced this issue Sep 8, 2013
@weotch
Moving the pattern into a function in preparation for adding a restri…
07fdc06 
…ction on upload directory.

See #13
@weotch
Copy link
Member Author

weotch commented Sep 8, 2013

Yeah, do it as config option. Most host in there too. And get rid of that new one you are merging in for public directory. The search dirs should be used for that.

@weotch
Copy link
Member Author

weotch commented Oct 29, 2013

Still getting it: https://bkwld.codebasehq.com/projects/equil/exceptions/6bcb21d9-ad93-0e4a-e24e-cdb35f175abb. Path: http://myequil.com/apple-touch-icon-120x120.png

@weotch
Copy link
Member Author

weotch commented Jan 26, 2015

And with /apple-touch-icon-152x152-precomposed.png

@weotch weotch mentioned this issue Feb 6, 2015
Closed
@weotch weotch closed this as completed in d694710 Feb 7, 2015
weotch added a commit that referenced this issue Feb 7, 2015
@weotch
Making the src_dir more flexible
4c8e61b 
This allows the src_dir == public config
#13
@weotch weotch mentioned this issue Mar 2, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weotch