Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing reference to the deprecated Centre() method #519

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Removing reference to the deprecated Centre() method #519

merged 1 commit into from
Jan 11, 2021

Conversation

LMarkowski
Copy link

@LMarkowski LMarkowski commented Jan 11, 2021 •
edited
Loading

NOTE: Depends on

#2263 Main pull request in the Geometry_Engine.

Issues addressed by this PR

Replacing reference to Centre() with Centroid().

Changelog

  • Updating Opening method to call for Centroid instead of Centre.

@LMarkowski LMarkowski added the type:bug Error or unexpected behaviour label Jan 11, 2021
@LMarkowski LMarkowski requested a review from tg359 as a code owner January 11, 2021 15:59
@LMarkowski LMarkowski self-assigned this Jan 11, 2021
@LMarkowski LMarkowski mentioned this pull request Jan 11, 2021
Merged
@LMarkowski
Copy link
Author

@BHoMBot check compliance

1 similar comment
@LMarkowski
Copy link
Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 11, 2021

@LMarkowski to confirm, check-code-compliance, check-documentation-compliance, check-project-compliance, check-branch-compliance, check-dataset-compliance, and, if applicable, check-copyright-compliance tasks are now queued.

FraserGreenroyd
FraserGreenroyd approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - am merging as this isn't truly dependent on the BHoM_Engine branch.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 11, 2021

@FraserGreenroyd to confirm, check-installer task is now queued.

@FraserGreenroyd FraserGreenroyd added type:compliance Non-conforming to code guidelines and removed type:bug Error or unexpected behaviour labels Jan 11, 2021
@FraserGreenroyd FraserGreenroyd merged commit 97fb7dc into master Jan 11, 2021
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-#944-RemoveCentre(Polyline) branch January 11, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@tg359 tg359 Awaiting requested review from tg359

Assignees

@LMarkowski LMarkowski

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LMarkowski @FraserGreenroyd