Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update namespace #470

Merged
merged 3 commits into from
May 21, 2020
Merged

Update namespace #470

merged 3 commits into from
May 21, 2020

Conversation

MajaLindroth
Copy link
Contributor

Issues addressed by this PR

Closes #469

Updated Spacename to "Adapters"
Updated Versioning JSON file

Test files

Changelog

Additional comments

@MajaLindroth MajaLindroth added the type:compliance Non-conforming to code guidelines label May 21, 2020
@MajaLindroth MajaLindroth added this to the BHoM 3.2 β MVP milestone May 21, 2020
@MajaLindroth MajaLindroth self-assigned this May 21, 2020
FraserGreenroyd
FraserGreenroyd requested changes May 21, 2020
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor things which need putting back but otherwise the code looks good

XML_Adapter/CRUD/GBXML/ReadGBXML.cs Outdated
using BHX = BH.Adapter.XML.GBXMLSchema;
using BHC = BH.oM.Physical.Constructions;

using BH.oM.Adapter;
using BH.oM.Adapters;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should be left as BH.oM.Adapter

XML_Adapter/CRUD/Read.cs Outdated
using BHX = BH.Adapter.XML.GBXMLSchema;
using BHC = BH.oM.Physical.Constructions;

using BH.oM.Adapter;
using BH.Engine.Adapter;
using BH.Engine.Adapters;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be left as BH.Engine.Adapter

@FraserGreenroyd FraserGreenroyd changed the title Update spacename Update namespace May 21, 2020
FraserGreenroyd
FraserGreenroyd approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and works as expected, thanks @MajaLindroth 😄

@FraserGreenroyd FraserGreenroyd merged commit cf4044b into master May 21, 2020
@FraserGreenroyd FraserGreenroyd deleted the XML_Toolkit-#469-Update-Spacename branch May 21, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@tg359 tg359 Awaiting requested review from tg359

Assignees

@MajaLindroth MajaLindroth

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
BHoM 3.2 β MVP
Development

Successfully merging this pull request may close these issues.

Update namespace
2 participants
@MajaLindroth @FraserGreenroyd