Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using Hole as ElementType #468

Merged
merged 1 commit into from
May 20, 2020
Merged

Using Hole as ElementType #468

merged 1 commit into from
May 20, 2020

Conversation

MajaLindroth
Copy link
Contributor

NOTE: Depends on

BHoM/BHoM#878

Issues addressed by this PR

Added Hole to OpeningType

Test files

Changelog

Additional comments

@MajaLindroth MajaLindroth added the type:feature New capability or enhancement label May 20, 2020
@MajaLindroth MajaLindroth added this to the BHoM 3.2 β MVP milestone May 20, 2020
@MajaLindroth MajaLindroth self-assigned this May 20, 2020
@FraserGreenroyd FraserGreenroyd changed the title Hole as ElementType Using Hole as ElementType May 20, 2020
@FraserGreenroyd FraserGreenroyd mentioned this pull request May 20, 2020
Merged
@al-fisher al-fisher merged commit a79c615 into master May 20, 2020
@al-fisher al-fisher deleted the Environment_oM-#763-Add-Hole branch May 20, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@tg359 tg359 Awaiting requested review from tg359

Assignees

@MajaLindroth MajaLindroth

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
BHoM 3.2 β MVP
Development

Successfully merging this pull request may close these issues.
3 participants
@MajaLindroth @FraserGreenroyd @al-fisher