Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve BHoM Upgrader handling of types #67

Merged

Conversation

adecler
Copy link
Member

@adecler adecler commented Apr 14, 2020

Issues addressed by this PR

The key change in this PR is the fact that upgrading a type that doesn't have any versioning information is now returning null (like for object and method) instead of the input type. Otherwise, simply making sure that methods can update their internal types through the chain.

Test files

Any old file you have at hand. See more links from #66

Changelog

  • Fix recursive triggering not happening for Old mode of serialisation
  • Fix Method upgrader reporting false "modified" types
  • Upgrader now calling upgrade methods recursively for sub types

@adecler adecler added type:bug Error or unexpected behaviour type:feature New capability or enhancement labels Apr 14, 2020
@adecler adecler added this to the BHoM 3.2 β MVP milestone Apr 14, 2020
@adecler adecler requested a review from IsakNaslundBh April 14, 2020 09:32
@adecler adecler self-assigned this Apr 14, 2020
@adecler adecler requested a review from kThorsager April 15, 2020 02:33
Copy link
Contributor

@kThorsager kThorsager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a few scripts in Grasshopper pre 2.4 and some post which used Versioning and all worked well

LGTM

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testscripts running fine

@IsakNaslundBh IsakNaslundBh merged commit 5cdfe18 into master Apr 15, 2020
@IsakNaslundBh IsakNaslundBh deleted the Versioning_Toolkit-#61-FixFalseReportOfModfiedType branch April 15, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour type:feature New capability or enhancement
Projects
None yet
3 participants