-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versioning for Inspection.Audit #150
Versioning for Inspection.Audit #150
Conversation
@BHoMBot check versioning |
@FraserGreenroyd to confirm, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, removes all versioning issues, I love it ❤️
@BHoMBot check installer |
@FraserGreenroyd to confirm, |
@BHoMBot check copyright-compliance |
@FraserGreenroyd to confirm, |
Issues addressed by this PR
Closes #149
Audit
was modified in BHoM/BHoM#1178 without versioning. This PR fixes that.Test files
Provide the following string to a
FromJson
component and make sure it returns aAudit
object.The string above is the serialised version of an
Audit
object from BHoM 4.0.Changelog
Additional comments
I have also fixed the serialised version of the generic
OutputTree<T>
as it had been incorrectly stored in the test dataset for CI/CD. @BSochacki , @enarhi , don't worry about that part unless it makes sense to you. That's for @FraserGreenroyd to check.