Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning for Inspection.Audit #150

Merged
merged 2 commits into from
Mar 23, 2021

Conversation

adecler
Copy link
Member

@adecler adecler commented Mar 19, 2021

Issues addressed by this PR

Closes #149

Audit was modified in BHoM/BHoM#1178 without versioning. This PR fixes that.

Test files

Provide the following string to a FromJson component and make sure it returns a Audit object.

{ "_t" : "BH.oM.Inspection.Audit", "BHoM_Guid" : "aa4bdbe3-22ea-4993-ac67-d5544ee56763", "Name" : "test", "Fragments" : [], "Tags" : [], "CustomData" : { "test" : "test" }, "Title" : "test", "Filename" : "test", "AuditID" : "test", "SiteVisitNumber" : 42, "Client" : "test", "RevisionNumber" : 42, "InspectionDate" : { "$date" : -62135596800000 }, "InspectionDateUtc" : { "$date" : -62135596800000 }, "IssueDate" : { "$date" : -62135596800000 }, "IssueDateUtc" : { "$date" : -62135596800000 }, "Author" : "test", "ProjectNumber" : "test", "JobLeader" : "test", "Distribution" : ["test"], "Attendance" : ["test"], "VisitPurpose" : "test", "AreasInspected" : ["test"], "InstallationProgressObjects" : [{ "_t" : "BH.oM.Inspection.InstallationProgress", "BHoM_Guid" : "cd77ad3d-7442-4eca-bddf-2b777fbc860e", "Name" : "test", "Fragments" : [], "Tags" : [], "CustomData" : { "test" : "test" }, "Status" : "test", "Area" : "test", "Media" : ["test"] }], "Issues" : [{ "_t" : "BH.oM.Inspection.Issue", "BHoM_Guid" : "b3b91800-1a3d-4607-8215-f1e42efc2c7b", "Name" : "test", "Fragments" : [], "Tags" : [], "CustomData" : { "test" : "test" }, "IssueNumber" : "test", "DateCreated" : { "$date" : -62135596800000 }, "Priority" : "test", "Status" : "test", "Assign" : ["test"], "Type" : "test", "Description" : "test", "Media" : ["test"], "Position" : { "_t" : "BH.oM.Geometry.Point", "X" : 42.420000000000002, "Y" : 42.420000000000002, "Z" : 42.420000000000002 }, "Comments" : [{ "_t" : "BH.oM.Inspection.Comment", "BHoM_Guid" : "d7800e7a-cd11-4944-b5f9-5f4f6a156c04", "Name" : "test", "Fragments" : [], "Tags" : [], "CustomData" : { "test" : "test" }, "Message" : "test", "Owner" : "test", "CommentDate" : { "$date" : -62135596800000 } }] }], "Score" : "test" }

The string above is the serialised version of an Audit object from BHoM 4.0.

Changelog

Additional comments

I have also fixed the serialised version of the generic OutputTree<T> as it had been incorrectly stored in the test dataset for CI/CD. @BSochacki , @enarhi , don't worry about that part unless it makes sense to you. That's for @FraserGreenroyd to check.

@adecler adecler self-assigned this Mar 19, 2021
@adecler adecler added type:bug Error or unexpected behaviour type:compliance Non-conforming to code guidelines labels Mar 19, 2021
@adecler adecler added this to the BHoM 4.1 β Release milestone Mar 19, 2021
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 23, 2021

@FraserGreenroyd to confirm, check-versioning task is now queued.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, removes all versioning issues, I love it ❤️

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 23, 2021

@FraserGreenroyd to confirm, check-installer task is now queued.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 23, 2021

@FraserGreenroyd to confirm, check-copyright-compliance task is now queued.

@FraserGreenroyd FraserGreenroyd merged commit aad691a into master Mar 23, 2021
@FraserGreenroyd FraserGreenroyd deleted the Versioning_Toolkit-#149-VersioningForAudit branch March 23, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inspection.IAudit doesn't deserialise from version 4.0
2 participants