Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with changes in Structure_Engine #85

Merged

Conversation

IsakNaslundBh
Copy link
Contributor

NOTE: Depends on

Done is support of, but compiles without BHoM/BHoM_Engine#2738

Issues addressed by this PR

Align with removed methods from Structure_Engine

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Jan 24, 2022
@IsakNaslundBh IsakNaslundBh requested a review from alelom January 24, 2022 08:17
@IsakNaslundBh IsakNaslundBh self-assigned this Jan 24, 2022
@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2022

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2022

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance
  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 190 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2022

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes align with the changes in the Engine.

Code compliance is an issue @alelom still needs to resolve but is out of scope for this PR alignment work so will dispensate.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 25, 2022

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is code-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 4924387477

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 4924387477

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 25, 2022

@FraserGreenroyd I have now provided a passing check on reference 4924387477 as requested.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 25, 2022

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit c46ad26 into main Jan 25, 2022
@FraserGreenroyd FraserGreenroyd deleted the Structure_Engine-#2736-CleanUpToBeRemovedMethod branch January 25, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants