-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align with changes in Structure_Engine #85
Align with changes in Structure_Engine #85
Conversation
@IsakNaslundBh just to let you know, I have provided a |
1 similar comment
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh just to let you know, I have provided a |
1 similar comment
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh to confirm, the following checks are now queued:
There are 190 requests in the queue ahead of you. |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes align with the changes in the Engine.
Code compliance is an issue @alelom still needs to resolve but is out of scope for this PR alignment work so will dispensate.
FAO: @FraserGreenroyd The check they wish to have dispensation on is code-compliance. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 4924387477 |
@FraserGreenroyd I have now provided a passing check on reference |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
NOTE: Depends on
Done is support of, but compiles without BHoM/BHoM_Engine#2738
Issues addressed by this PR
Align with removed methods from Structure_Engine
Test files
Changelog
Additional comments