Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAS_Toolkit: Relinking FindFragment #306

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

robinflyman
Copy link
Contributor

NOTE: Depends on

BHoM/BHoM_Engine#2748

Issues addressed by this PR

Fixing compilation failures that was caused by moving and removing FindFragment in Environment_Engine.

Closes #2747

Have relinked FindFragment in relevant file.

@robinflyman robinflyman requested a review from tg359 as a code owner February 10, 2022 17:11
@robinflyman robinflyman self-assigned this Feb 10, 2022
@robinflyman robinflyman added the type:compliance Non-conforming to code guidelines label Feb 10, 2022
@bhombot-ci
Copy link

bhombot-ci bot commented Feb 11, 2022

@robinflyman just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @robinflyman on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 11, 2022

@robinflyman just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required
@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 11, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer
  • copyright-compliance

There are 2 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 11, 2022

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 11, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the Engine PR, tack @robinflyman

@FraserGreenroyd FraserGreenroyd merged commit 89d4c6b into main Feb 11, 2022
@FraserGreenroyd FraserGreenroyd deleted the Environment_Engine-#2747-RemoveFindFragment branch February 11, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants