-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align with changes in oM and Engine on Reflection -> Base #304
Conversation
@FraserGreenroyd just to let you know, I have provided a |
@BHoMBot check project-compliance |
@FraserGreenroyd to confirm, the following checks are now queued:
There are 13 requests in the queue ahead of you. |
@FraserGreenroyd fix requested for project compliance. The errors with the CSProject ( I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with:
|
@BHoMBot fix project file ref. 4788312320 |
@FraserGreenroyd I am now going to fix the CSProject compliance in accordance with the annotations previously made. |
@FraserGreenroyd to confirm I have now resolved the CSProject compliance issues and pushed a commit to this Pull Request. |
@BHoMBot check project-compliance |
@FraserGreenroyd to confirm, the following checks are now queued:
There are 12 requests in the queue ahead of you. |
@FraserGreenroyd just to let you know, I have provided a |
@FraserGreenroyd just to let you know, I have provided a |
@FraserGreenroyd just to let you know, I have provided a |
1 similar comment
@FraserGreenroyd just to let you know, I have provided a |
@FraserGreenroyd just to let you know, I have provided a |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, code-compliance, copyright-compliance, dataset-compliance, documentation-compliance, null-handling, project-compliance, ready-to-merge, serialisation |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on discussion with @FraserGreenroyd as part of the merge party to merge in this work. Core work was reviewed by @IsakNaslundBh and @adecler during the week. This approval is given to allow merge, with checks on installer and versioning from BHoMBot being sufficient to show compilation upgrade to the core changes reviewed by others.
NOTE: Depends on
BHoM/BHoM#1339
BHoM/BHoM_Engine#2729
BHoM/BHoM_Adapter#318
Issues addressed by this PR
Test files
Changelog
Additional comments