Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesh to STL #33

Merged
merged 3 commits into from
Feb 4, 2021
Merged

Mesh to STL #33

merged 3 commits into from
Feb 4, 2021

Conversation

BingWangUS
Copy link
Contributor

@BingWangUS BingWangUS commented Feb 2, 2021 •
edited
Loading

NOTE: Depends on

Issues addressed by this PR

Closes #4
Closes #5

Test files

STLToolkit_#4_Mesh.zip

Changelog

  • Modify ToPolyline method to handle mesh file

Additional comments

@BingWangUS BingWangUS added the type:feature New capability or enhancement label Feb 2, 2021
@BingWangUS BingWangUS added this to the BHoM 4.1 β RC milestone Feb 2, 2021
@BingWangUS BingWangUS self-assigned this Feb 2, 2021
@BingWangUS
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 2, 2021

@BingWangUS to confirm, check-code-compliance, check-documentation-compliance, check-project-compliance, check-branch-compliance, check-dataset-compliance, and, if applicable, check-copyright-compliance tasks are now queued.

@BingWangUS
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 2, 2021

@BingWangUS to confirm, check-installer task is now queued.

@BingWangUS BingWangUS mentioned this pull request Feb 2, 2021
Closed
FraserGreenroyd
FraserGreenroyd reviewed Feb 2, 2021
View reviewed changes
Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment as a query, might not be relevant if closed polylines aren't needed.

STL_Engine/Convert/ToPolyline.cs Show resolved Hide resolved
@BingWangUS
Copy link
Contributor Author

BingWangUS commented Feb 2, 2021 •
edited
Loading

Thank you both for helping on this. Resolved now.

@BingWangUS
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 2, 2021

@BingWangUS to confirm, check-code-compliance, check-documentation-compliance, check-project-compliance, check-branch-compliance, check-dataset-compliance, and, if applicable, check-copyright-compliance tasks are now queued.

@BingWangUS
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 2, 2021

@BingWangUS to confirm, check-installer task is now queued.

@BingWangUS BingWangUS requested a review from svaz00 February 2, 2021 16:52
vbeardow
vbeardow approved these changes Feb 3, 2021
View reviewed changes
Copy link

@vbeardow vbeardow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FraserGreenroyd FraserGreenroyd merged commit ab79174 into master Feb 4, 2021
@FraserGreenroyd FraserGreenroyd deleted the STL_Toolkit-#4-MeshToSTL branch February 4, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@vbeardow vbeardow vbeardow approved these changes

@svaz00 svaz00 Awaiting requested review from svaz00

Assignees

@BingWangUS BingWangUS

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
BHoM 4.1 β RC
Development

Successfully merging this pull request may close these issues.

STL_Toolkit: Donut shape geometry STL_Toolkit: Complex geometry
3 participants
@BingWangUS @FraserGreenroyd @vbeardow