Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.2 Deployment #55

Merged
merged 2 commits into from
Jun 20, 2024
Merged

7.2 Deployment #55

merged 2 commits into from
Jun 20, 2024

Conversation

bhombot-ci[bot]
Copy link

@bhombot-ci bhombot-ci bot commented Jun 10, 2024

SQL_Toolkit

Compliance

@michaelhoehn michaelhoehn added the type:feature New capability or enhancement label Jun 10, 2024
@michaelhoehn
Copy link

@BHoMBot check compliance

@michaelhoehn
Copy link

@BHoMBot check serialisation
@BHoMBot check null-handling

Copy link
Author

bhombot-ci bot commented Jun 17, 2024

@michaelhoehn to confirm, the following actions are now queued:

  • check serialisation
  • check null-handling

There are 342 requests in the queue ahead of you.

Copy link
Author

bhombot-ci bot commented Jun 19, 2024

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@IsakNaslundBh IsakNaslundBh requested a review from adecler June 20, 2024 08:40
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on the following

  • Tested on a series of my local scripts that are using the SQL Adapter. Those are purely on pulling but, given that there is no testing procedure for this toolkit, this is the best I could do in short notice.
  • No change to the code in this milestone

@IsakNaslundBh
Copy link
Contributor

IsakNaslundBh commented Jun 20, 2024

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core

Copy link
Author

bhombot-ci bot commented Jun 20, 2024

@IsakNaslundBh I'm sorry, but I am not authorised to take that instruction from you.

Copy link
Author

bhombot-ci bot commented Jun 20, 2024

@IsakNaslundBh I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: installer

Copy link
Author

bhombot-ci bot commented Jun 20, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: installer

Copy link
Author

bhombot-ci bot commented Jun 20, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 26467434697

Copy link
Author

bhombot-ci bot commented Jun 20, 2024

@FraserGreenroyd I have now provided a passing check on reference 26467434697 as requested.

@FraserGreenroyd
Copy link

@BHoMBot check compliance

Copy link
Author

bhombot-ci bot commented Jun 20, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 37 requests in the queue ahead of you.

@adecler
Copy link
Member

adecler commented Jun 20, 2024

@BHoMBot check compliance

Copy link
Author

bhombot-ci bot commented Jun 20, 2024

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 61 requests in the queue ahead of you.

Copy link
Author

bhombot-ci bot commented Jun 20, 2024

The check beta-project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Author

bhombot-ci bot commented Jun 20, 2024

The check beta-branch-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Author

bhombot-ci bot commented Jun 20, 2024

@bhombot-ci[bot] just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on Excel_UI

@al-fisher al-fisher merged commit 7e28b0a into main Jun 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants