Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Working rigid links with new name/ID convention #189

Merged
merged 6 commits into from
Jan 15, 2021
Merged

Working rigid links with new name/ID convention #189

merged 6 commits into from
Jan 15, 2021

Conversation

maryannewachter
Copy link
Member

JosefTaylor
JosefTaylor approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@JosefTaylor JosefTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I simplified the filtering LINQ query at the end- please review!

@maryannewachter
Copy link
Member Author

maryannewachter commented Jan 14, 2021 •
edited
Loading

Looks great, I simplified the filtering LINQ query at the end- please review!

New LINQ query LGTM.

JosefTaylor
JosefTaylor suggested changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@JosefTaylor JosefTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be able to simply delete

SAP2000_Engine/SAP2000_Engine.csproj Outdated Show resolved Hide resolved
@JosefTaylor
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2021

@JosefTaylor sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to run?
For example, if you would like me to run the check-core comment:

"@BHoMBot check core"

@JosefTaylor
Copy link
Contributor

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2021

@JosefTaylor to confirm, check-core task is now queued.

@JosefTaylor
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2021

@JosefTaylor to confirm, check-code-compliance, check-documentation-compliance, check-project-compliance, check-branch-compliance, check-dataset-compliance, and, if applicable, check-copyright-compliance tasks are now queued.

@JosefTaylor
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2021

@JosefTaylor to confirm, check-installer task is now queued.

FraserGreenroyd
FraserGreenroyd approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we raise an issue to address the failing compliance issue at a future date? If so I'm happy to approve this from a CI perspective with the last changes to the .csproj file 😄

Oh, and a label please for the change log!

@JosefTaylor JosefTaylor added the type:bug Error or unexpected behaviour label Jan 14, 2021
@JosefTaylor
Copy link
Contributor

@FraserGreenroyd yeah- I looked at the issue and we either need to make these methods private or work out some grasshopper issues. I'd appreciate if you let us ignore that check, and I'll raise an issue!

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 15, 2021

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is code-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a CI/CD instruction. I am authorising dispensation to be granted on check ref. 1705030356

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a CI/CD instruction. I am authorising dispensation to be granted on check ref. 1705030356

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 15, 2021

@FraserGreenroyd I have now provided a passing check on reference 1705030356 as requested.

@FraserGreenroyd FraserGreenroyd merged commit 70a068b into master Jan 15, 2021
@FraserGreenroyd FraserGreenroyd deleted the SAP2000_Toolkit-#188-Cannot-pull-or-push-rigid-links branch January 15, 2021 08:13
@JosefTaylor
Copy link
Contributor

new issue raised for the compliance issue: #190

@FraserGreenroyd
Copy link
Contributor

Cheers @JosefTaylor 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@jeanlucjackson jeanlucjackson Awaiting requested review from jeanlucjackson

@enarhi enarhi Awaiting requested review from enarhi

@JosefTaylor JosefTaylor Awaiting requested review from JosefTaylor

Assignees
No one assigned
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot Pull or Push Rigid Links to SAP2000 v21
3 participants
@maryannewachter @JosefTaylor @FraserGreenroyd