Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Assembly Version #179

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Update Assembly Version #179

merged 1 commit into from
Dec 21, 2020

Conversation

BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Dec 20, 2020 •
edited by FraserGreenroyd
Loading

Closes #172

@FraserGreenroyd FraserGreenroyd self-requested a review December 20, 2020 17:17
@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Dec 20, 2020
@bhombot-ci
Copy link

bhombot-ci bot commented Dec 20, 2020

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on LadybugTools_Toolkit

FraserGreenroyd
FraserGreenroyd approved these changes Dec 20, 2020
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed from a CI/CD perspective.

IsakNaslundBh
IsakNaslundBh approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IsakNaslundBh
Copy link
Contributor

/azp run SAP2000_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@IsakNaslundBh IsakNaslundBh merged commit 6e9f335 into master Dec 21, 2020
@IsakNaslundBh IsakNaslundBh deleted the BHoMBot-UpdateAssemblyVersion branch December 21, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsakNaslundBh IsakNaslundBh IsakNaslundBh approved these changes

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@JosefTaylor JosefTaylor Awaiting requested review from JosefTaylor

Assignees
No one assigned
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update AssemblyFileVersion
3 participants
@BHoMBot @IsakNaslundBh @FraserGreenroyd