Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace calls to GetShallowClone with ShallowClone #170

Merged

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Nov 27, 2020

Issues addressed by this PR

Closes #169

See BHoM/admin#9

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:compliance Non-conforming to code guidelines label Nov 27, 2020
@IsakNaslundBh IsakNaslundBh self-assigned this Nov 27, 2020
Copy link
Member

@al-fisher al-fisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@al-fisher
Copy link
Member

/azp run SAP2000_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 6, 2021

@FraserGreenroyd to confirm, check-installer task is now queued.

@FraserGreenroyd FraserGreenroyd merged commit f40386c into master Jan 6, 2021
@FraserGreenroyd FraserGreenroyd deleted the SAP2000_Toolkit-#169-RemoveCallsToGetShallowClone branch January 6, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAP2000_Toolkit: Replace calls to Clone methods with calls to Base DeepClone or ShallowClone
3 participants