Return XY basis if node is not oriented to Global Coordinates. #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosefTaylor
requested review from
enarhi,
karlybast,
maryannewachter and
jeanlucjackson
JosefTaylor
added
size:S
|
/azp run SAP2000_Toolkit.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #124
Return xy orientation for nodes when they are defined in an unsupported coordinate system, rather than failing in the push
Test files
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/01_Test%20Scripts/SAP2000_Toolkit/091%20-%20Issue%20-%20Support%20Node%20Orientation?csf=1&web=1&e=E9i3og
Use with accompanying SAP file, or create a new SAP model with a node with advanced local axes defined by a non-global coordinate system.
Changelog
Additional comments