Align property modifier changes with changes in BHoM #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsakNaslundBh
added
the
type:external-api-changes
|
@JosefTaylor as this is blocking the oM and Engine from being merged, would be thankful if you would have time to review this as soon as possible. Preferably if you have some time today, so we can merge on monday! |
JosefTaylor
approved these changes
May 29, 2020
|
/azp run SAP2000_Toolkit.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
IsakNaslundBh
deleted the
Structure_oM-#578-AddModifierFragmentFromProperties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
BHoM/BHoM#895
BHoM/BHoM_Engine#1809
Issues addressed by this PR
Closes #116
Update property modifiers to work with new Fragment instead of custom data.
Test files
Changelog
Additional comments