Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of caching system in base adapter #504

Merged
merged 14 commits into from
Jan 24, 2023
Merged

Make use of caching system in base adapter #504

merged 14 commits into from
Jan 24, 2023

Conversation

IsakNaslundBh
Copy link
Contributor

NOTE: Depends on

BHoM/BHoM_Adapter#337
intentionally using different branch names to let the Adapter PR be merged separately.

Issues addressed by this PR

Closes #503

Make use of the Caching system added to the Base adapter. Aim for this to speed up the push process, especially for higher level objects.

Test files

Changelog

Additional comments

@IsakNaslundBh
Update SurfaceProperties.cs
335933a
@IsakNaslundBh
Update Labels.cs
46293c4
@IsakNaslundBh
Update Bars.cs
c92a8ff
@IsakNaslundBh
Update Groups.cs
1193fc3
@IsakNaslundBh
Update Nodes.cs
8be7bc8
@IsakNaslundBh
Update RigidLinks.cs
1037cee
@IsakNaslundBh
Update Loads.cs
bb1a4b9
@IsakNaslundBh
Additional check on edge releases and supports before any comcalls ar…
8edf926 
…e made

Nullcheck everything before trying to make COM calls to limit them as much as possible.

Unrelated to other changes made, but should give a slight speedup in panel pushes
@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Jan 17, 2023
@IsakNaslundBh IsakNaslundBh requested a review from alelom January 17, 2023 12:52
@IsakNaslundBh IsakNaslundBh self-assigned this Jan 17, 2023
alelom
alelom previously approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. I used the create-read test script and it works well.

@alelom
Copy link
Member

alelom commented Jan 23, 2023

@BHoMBot check compliance
@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 23, 2023

@alelom to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core

There are 2 requests in the queue ahead of you.

@IsakNaslundBh
Add concrete dispatching over as dynamic
a39b098 
Fix for now. Previous code should, and was, working, but stopped. Changing to explicit type checking and casting to make code work for now
@alelom alelom self-requested a review January 23, 2023 12:09
alelom
alelom approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving after changes that fix the failed test with Create-Read Loads. Test script is now successful.

@alelom
Copy link
Member

alelom commented Jan 23, 2023

@BHoMBot check compliance
@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 23, 2023

@alelom to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check required

1 similar comment
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2023

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

There are 8 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh merged commit 5839457 into develop Jan 24, 2023
@IsakNaslundBh IsakNaslundBh deleted the Robot_Toolkit-#503-MakeUseOfCachingSystemInBaseAdapter branch January 24, 2023 15:07
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alelom alelom alelom approved these changes

Assignees

@IsakNaslundBh IsakNaslundBh

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make use of Caching system
2 participants
@IsakNaslundBh @alelom