Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robot_Toolkit: Fix MeshResults crash on non-planar meshes #453

Merged
merged 4 commits into from
Mar 12, 2021

Conversation

IsakLarbornBH
Copy link
Contributor

@IsakLarbornBH IsakLarbornBH commented Feb 11, 2021

Issues addressed by this PR

Closes #452

Fixes crash in MeshResultRequest pulls on non-planar meshes, by making them use FEMesh objects instead of Panel.

Test files

A test file can be found on the issue page. I'd make Unit tests if I knew how they worked for adapter methods.

Additional comments

  • With this change the ObjectIds parameter in MeshResultRequests does nothing, results for all meshes are always returned. This seems to be, as far as I can tell, due to ReadMeshes() not using its List<string> ids input.
  • The new version is slightly slower, likely due to using the full ReadMeshes() method instead of ReadPanelsLight(). The difference is less than 5% though, so it's not a huge deal. Reading the actual results appears to be what takes the most time by far.

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testfile runs fine.

Also tested with the standard pull result script, and things seem to be working jsut fine there as well!

Approved!

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 12, 2021

@IsakNaslundBh to confirm, check-installer task is now queued.

@IsakNaslundBh IsakNaslundBh merged commit a65fb36 into master Mar 12, 2021
@IsakNaslundBh IsakNaslundBh deleted the Robot_Toolkit-#452-MeshResultsNonPlanar branch March 12, 2021 12:58
@FraserGreenroyd FraserGreenroyd added the type:bug Error or unexpected behaviour label Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Robot_Toolkit: Robot crashing when pulling in MeshResultRequest for non-planar meshes
3 participants