Robot_Toolkit: Fix MeshResults crash on non-planar meshes #453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #452
Fixes crash in
MeshResultRequest
pulls on non-planar meshes, by making them useFEMesh
objects instead ofPanel
.Test files
A test file can be found on the issue page. I'd make Unit tests if I knew how they worked for adapter methods.
Additional comments
ObjectIds
parameter inMeshResultRequests
does nothing, results for all meshes are always returned. This seems to be, as far as I can tell, due toReadMeshes()
not using itsList<string> ids
input.ReadMeshes()
method instead ofReadPanelsLight()
. The difference is less than 5% though, so it's not a huge deal. Reading the actual results appears to be what takes the most time by far.