Fixing robot BarForce signs flipped #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsakNaslundBh
added
severity:critical
IsakNaslundBh
requested review from
al-fisher,
johannaisak,
pawelbaran and
peterjamesnugent
peterjamesnugent
requested changes
Jun 25, 2020
|
/azp run Robot_Toolkit.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
peterjamesnugent
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #397
As stated in issue, somewhere in refactoring, the sign change for the values of the BarForce where being missed. Adding those signs previously used back in.
Test files
https://burohappold.sharepoint.com/:f:/s/BHoM/EqqZu_1Sr0lIkfBdRPg8TBQBBsLM3bh3YedOFyiiI5-_tA?e=FnxOW6
Changelog
Additional comments