Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fallback method for load convert to robot #393

Merged

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Closes #392

Fallback methods for converts ToRobot for ILoad existed, but had the wrong name and missing input parameters.

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/Em_LdUZqgX1KuIVqdNMiGJcBlPpuLhdHOREUu3lv_eSfTQ?e=9HKkrE

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Jun 17, 2020
@IsakNaslundBh IsakNaslundBh added this to the BHoM 3.2 β RC milestone Jun 17, 2020
@IsakNaslundBh IsakNaslundBh self-assigned this Jun 17, 2020
Copy link
Contributor

@kThorsager kThorsager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test file works

@IsakNaslundBh
Copy link
Contributor Author

/azp run Robot_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@IsakNaslundBh IsakNaslundBh merged commit f9fa7bc into master Jun 17, 2020
@IsakNaslundBh IsakNaslundBh deleted the Robot_Toolkit-#392-FixFallbackMethodForLoadConvertToRobot branch June 17, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
2 participants