Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bar names in push/pull to/from Robot, as well as update only #386

Merged
merged 3 commits into from
Jun 10, 2020

Conversation

rwemay
Copy link
Member

@rwemay rwemay commented Jun 10, 2020

NOTE: Depends on

Issues addressed by this PR

Closes #385
Closes #381

Test files

Test Script

Changelog

Additional comments

@rwemay rwemay requested a review from IsakNaslundBh June 10, 2020 13:40
@rwemay rwemay self-assigned this Jun 10, 2020
@rwemay rwemay added size:S Measured in minutes type:feature New capability or enhancement labels Jun 10, 2020
@rwemay
Copy link
Member Author

rwemay commented Jun 10, 2020

@IsakNaslundBh , one to note on the update method... the Name property of RobotBar is read only. There is a .Replace(String old, String new) but it did not work. I found the link below that does not have much information... but suggested using NameTemplate, which is settable. This seems to work...

https://knowledge.autodesk.com/support/robot-structural-analysis-products/learn-explore/caas/sfdcarticles/sfdcarticles/ROBOT-API-how-to-set-bar-name.html

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, and tests ok!

@IsakNaslundBh
Copy link
Contributor

/azp run Robot_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rwemay rwemay merged commit fa9cf96 into master Jun 10, 2020
@rwemay rwemay deleted the Robot_Toolkit-#385-Enable-bar-names-on-pull-and-push branch June 10, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S Measured in minutes type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push updated bar names to robot Add support for bar name create/read/update
2 participants