Adding push capability for orthotropic materials #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsakNaslundBh
requested changes
May 21, 2020
| else if (material is Timber) | ||
| { | ||
| Timber timber = material as Timber; | ||
| materialData.E = timber.YoungsModulus.X; |
There was a problem hiding this comment.
Suggested single warning message, replacing the warnings below.:
Engine.Reflection.Compute.RecordWarning("Due to limitations in the Material model for orthotropic Timber materials in Robot, the following assumptions have been made when converting the BHoM material to Robot:\n" +
"- Youngs modulus has been set to the x-component of the vector in the BHoM material.\n" +
"- Youngs modulus transversal has been set to the average of the y and z-component of the vector in the BHoM material\n" +
"- The ShearModulus (G) has been set to the average value of all components of the vector in the BHoM material\n" +
"- The Thermal Expansion Coefficient has been set to the x-component of the vector in the BHoM material\n" +
"- Poissons Ratio is ignored for timber materials.");
| materialData.E_Trans = Math.Abs((timber.YoungsModulus.Y+timber.YoungsModulus.Z)/2); | ||
| Engine.Reflection.Compute.RecordWarning("Young transverse modulue (timber) is an average between Y and Z axis due to Robot definition limitation"); | ||
| materialData.RO = timber.Density * Engine.Robot.Query.RobotGravityConstant; | ||
| materialData.Kirchoff = timber.ShearModulus.X;//Since shear modulus is expressed as shear stress over shear strain, longitudinal value is used as it is likely used for cross section analysis. |
There was a problem hiding this comment.
Would change this to the average value of the vector in BHoM
| Engine.Reflection.Compute.RecordWarning("Shear modulus in Y and Z axis are ignored due to Robot definition limitation"); | ||
| materialData.LX = timber.ThermalExpansionCoeff.X;//Value in X axis. Longitudinal expansion for bar element is likely of interets. | ||
| Engine.Reflection.Compute.RecordWarning("Thermal Expansion Coefficient in Y and Z axis are ignored due to Robot definition limitation"); | ||
| materialData.NU = timber.PoissonsRatio.X;//Poisson ratio in X axis. Longitudinal defomation under axial loading is likely of interests. |
There was a problem hiding this comment.
This can actually not be set through the UI in robot, so would completely skip setting this.
There was a problem hiding this comment.
I've deleted the PoissonsRatio for Timber material because as you mentioned it is not a component for Robot Timber material. I think thermalExpansionCoeff is steel worth keeping thought?
| Engine.Reflection.Compute.RecordWarning("Robot_Toolkit does currently only suport Isotropic material. No structural properties for material with name " + material.Name + " have been pushed"); | ||
| return; | ||
| IOrthotropic orthotropic = material as IOrthotropic; | ||
| materialData.E = orthotropic.YoungsModulus.X; |
There was a problem hiding this comment.
Missed copying in this warning as well:
Engine.Reflection.Compute.RecordWarning("Robot does not support generic orthotropic materials. Material pushed will be treated as an isotropic material, only taking the x-component of the values into acount.\n" +
"This means the y and z-components of the vectors for YoungsModulus, ShearModulus, PoissonsRatio and ThermalExpansionCoeff will be ignored.");
IsakNaslundBh
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #360
Test files
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/01_Test%20Scripts/Robot_Toolkit/Pull%20Requests/Push%20orthotropic%20materials?csf=1&web=1&e=jdsysw
Changelog
Additional comments