Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralise use of interactive mode in the adapter #361

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Apr 24, 2020

Issues addressed by this PR

Closes #251
Closes #344

Adds control over if robot should be interactive and or visible during push and pull.
I put the default values as Interactive = false, visible = true, but can all be changed via the interactive settings.

My initial testing shows a speed increase of ~10-20% when having any of the modes turned off, with a slight increase if both are off.

Test files

Any previous project or macro files:

https://burohappold.sharepoint.com/:f:/s/BHoM/Ehpg00-00uVCnniPvSXNPDoBJOf9zsA8HPSeN2tWd81Etw?e=ZkNKTS

And files used for testing:
https://burohappold.sharepoint.com/:f:/s/BHoM/Es5Zh865TptCkIDzTScpw1MBcO0Kwis3Y3OJQjotLPT-8w?e=725gbH

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added type:compliance Non-conforming to code guidelines type:feature New capability or enhancement labels Apr 24, 2020
@IsakNaslundBh IsakNaslundBh self-assigned this Apr 24, 2020
@IsakNaslundBh IsakNaslundBh added this to the BHoM 3.2 β MVP milestone Apr 24, 2020
@IsakNaslundBh IsakNaslundBh marked this pull request as ready for review April 30, 2020 13:53
Copy link
Contributor

@kThorsager kThorsager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and the tests work,

Was a bit curious however and tried force closing Rhino during a push and Robot was frozen afterwards. Was however easily amended by Pulling nothing afterwards, and also don't know how to keep it from happening so LGTM

@IsakNaslundBh
Copy link
Contributor Author

Code looks good and the tests work,

Was a bit curious however and tried force closing Rhino during a push and Robot was frozen afterwards. Was however easily amended by Pulling nothing afterwards, and also don't know how to keep it from happening so LGTM

Good catch. Not sure this can be caught as easily. Maybe in the finaliser, but would agree this is out of scope for this PR. Thanks!

@IsakNaslundBh IsakNaslundBh merged commit 7256b9e into master Apr 30, 2020
@IsakNaslundBh IsakNaslundBh deleted the Robot_Toolkit-#251-CentraliseUseOfInteractiveModeIntTheAdapter branch April 30, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Robot_Toolkit: Remove Common_Engine reference Robot_Toolkit: Centralise use of Interactive mode in adapter
2 participants