-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull loads and general load fixes #346
Conversation
@rwemay added link to some testfiles, one produced by @kThorsager when he added loads for Etabs, and one testing through the change to BarVaryingDistributed loads. If you have some models or so to test on as well, that would be great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the AreaLocalZ is reversed in Robot for the local one of the loads.
Pulling it back to BHoM resulted in the seme direction of the load which was pushed in
This pair:
ProjectedZ is empty and ProjectedY was never pushed
Error on push, can try my hand at debugging unless it's an obvious solution for those versed in Robot
1. This component failed to run properly.
- Error: Error HRESULT E_FAIL has been returned from a call to a COM component.
- Occured in BH.Adapter.Robot.RobotAdapter.CreateCollection(IEnumerable`1 loadCase)
called from BH.Adapter.Robot.RobotAdapter.ICreate[T](IEnumerable`1 objects, ActionConfig actionConfig)
- Are you sure you have the correct type of inputs? Check their description for more details.
Robot_Adapter/Convert/FromRobot/Loads/BarVaryingDistributedLoad.cs
Outdated
Show resolved
Hide resolved
…d.cs spelling fixes Co-Authored-By: Kalle Thorsager <[email protected]>
Added fix for Create/Read of panel normals, and added an additional test file for this. Good catch @kThorsager ! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ProjectedZ is empty and ProjectedY was never pushed
Error on push, can try my hand at debugging unless it's an obvious solution for those versed in Robot1. This component failed to run properly. - Error: Error HRESULT E_FAIL has been returned from a call to a COM component. - Occured in BH.Adapter.Robot.RobotAdapter.CreateCollection(IEnumerable`1 loadCase) called from BH.Adapter.Robot.RobotAdapter.ICreate[T](IEnumerable`1 objects, ActionConfig actionConfig) - Are you sure you have the correct type of inputs? Check their description for more details.
This is still a problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a problem with some loadcase numbers being equal, which is out of scope for this PR
and for the tolerance values for panel normal's see BHoM/BHoM#632 about some thoughts for wider actions
But works well now, LGTM
NOTE: Depends on
Issues addressed by this PR
Closes #120
Closes #238
Closes #202
Closes #125
Closes #211
Closes #347
Closes #348
Closes #351
Genral comb through of loads, and adding capability of pulling all implemented load types available in Robot and BHoM.
Also, cleaning up redundant unused enums.
Test files
Testing pushing through loads, comparing local, global projected:
https://burohappold.sharepoint.com/:u:/s/BHoM/EWJtw7n_SPdNtOdTVCOBkZsBccKJ2q5VdN4Dp8M1E5FwNQ?e=g5tnWE
Additional scripts:
https://burohappold.sharepoint.com/:f:/s/BHoM/ElNcfD7IGqVLrjrL1-zFvJ8BSOSYTZQF7Z3vea91Q5udJw?e=vOj54G
Panel normals:
https://burohappold.sharepoint.com/:f:/s/BHoM/EqbUk4v4hWlIpYaNoLKOKfkBisvSK_VdP3DVU518gLSLcQ?e=NIA3Kg
Changelog
Additional comments