Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull loads and general load fixes #346

Merged
merged 19 commits into from
Apr 8, 2020

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Apr 2, 2020

NOTE: Depends on

Issues addressed by this PR

Closes #120
Closes #238
Closes #202
Closes #125
Closes #211
Closes #347
Closes #348
Closes #351

Genral comb through of loads, and adding capability of pulling all implemented load types available in Robot and BHoM.

Also, cleaning up redundant unused enums.

Test files

Testing pushing through loads, comparing local, global projected:
https://burohappold.sharepoint.com/:u:/s/BHoM/EWJtw7n_SPdNtOdTVCOBkZsBccKJ2q5VdN4Dp8M1E5FwNQ?e=g5tnWE

Additional scripts:
https://burohappold.sharepoint.com/:f:/s/BHoM/ElNcfD7IGqVLrjrL1-zFvJ8BSOSYTZQF7Z3vea91Q5udJw?e=vOj54G

Panel normals:
https://burohappold.sharepoint.com/:f:/s/BHoM/EqbUk4v4hWlIpYaNoLKOKfkBisvSK_VdP3DVU518gLSLcQ?e=NIA3Kg

Changelog

  • Adding Pull functionality for load types not previously supported
  • Fixing issue where groups with names did not get the loads applied to the element (fixed by disabling the assignment of loads to named groups for now)
  • Fixing Gravity loads always applied to full model
  • Make gravity load not split up into component to correctly show factors
  • Fix wrong conversion for BarVaryingLoad between BHoM and Robot
  • Enabling local and Global axis as well as projected for all loads where applicable.
  • Fixing Panel normals sometimes read/created in flipped direction

Additional comments

@IsakNaslundBh IsakNaslundBh self-assigned this Apr 3, 2020
@IsakNaslundBh IsakNaslundBh added this to the BHoM 3.2 β MVP milestone Apr 3, 2020
@IsakNaslundBh IsakNaslundBh added type:bug Error or unexpected behaviour type:feature New capability or enhancement labels Apr 3, 2020
@IsakNaslundBh IsakNaslundBh changed the title Robot toolkit #120 pull all loads Pull loads and general load fixes Apr 3, 2020
@IsakNaslundBh IsakNaslundBh marked this pull request as ready for review April 3, 2020 16:55
@IsakNaslundBh IsakNaslundBh requested a review from kThorsager April 6, 2020 08:01
@IsakNaslundBh
Copy link
Contributor Author

@rwemay added link to some testfiles, one produced by @kThorsager when he added loads for Etabs, and one testing through the change to BarVaryingDistributed loads.

If you have some models or so to test on as well, that would be great!

Copy link
Contributor

@kThorsager kThorsager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the AreaLocalZ is reversed in Robot for the local one of the loads.
Pulling it back to BHoM resulted in the seme direction of the load which was pushed in
This pair:
image

ProjectedZ is empty and ProjectedY was never pushed
Error on push, can try my hand at debugging unless it's an obvious solution for those versed in Robot

1. This component failed to run properly.
- Error: Error HRESULT E_FAIL has been returned from a call to a COM component.
- Occured in  BH.Adapter.Robot.RobotAdapter.CreateCollection(IEnumerable`1 loadCase)
     called from BH.Adapter.Robot.RobotAdapter.ICreate[T](IEnumerable`1 objects, ActionConfig actionConfig)
- Are you sure you have the correct type of inputs? Check their description for more details.

@IsakNaslundBh IsakNaslundBh requested a review from kThorsager April 8, 2020 08:02
@IsakNaslundBh
Copy link
Contributor Author

Added fix for Create/Read of panel normals, and added an additional test file for this. Good catch @kThorsager ! 👍

Copy link
Contributor

@kThorsager kThorsager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProjectedZ is empty and ProjectedY was never pushed
Error on push, can try my hand at debugging unless it's an obvious solution for those versed in Robot

1. This component failed to run properly.
- Error: Error HRESULT E_FAIL has been returned from a call to a COM component.
- Occured in  BH.Adapter.Robot.RobotAdapter.CreateCollection(IEnumerable`1 loadCase)
     called from BH.Adapter.Robot.RobotAdapter.ICreate[T](IEnumerable`1 objects, ActionConfig actionConfig)
- Are you sure you have the correct type of inputs? Check their description for more details.

This is still a problem

Copy link
Contributor

@kThorsager kThorsager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a problem with some loadcase numbers being equal, which is out of scope for this PR

and for the tolerance values for panel normal's see BHoM/BHoM#632 about some thoughts for wider actions

But works well now, LGTM

@IsakNaslundBh IsakNaslundBh merged commit c6a1121 into master Apr 8, 2020
@IsakNaslundBh IsakNaslundBh deleted the Robot_Toolkit-#120-PullAllLoads branch April 8, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment