Call Create Group #343
Merged
Call Create Group #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kThorsager
commented
Mar 31, 2020
|
|
||
| if (objects.First() is IBHoMGroup) | ||
| { | ||
| success = CreateCollection(objects as dynamic); |
There was a problem hiding this comment.
No Idea how to get this to work otherwise
IsakNaslundBh
requested changes
Apr 9, 2020
IsakNaslundBh
deleted the
Robot_Toolkit-#339-Create-Group-is-never-called
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #339
Calls the Create Group and adds some error checking
Test files
https://burohappold.sharepoint.com/:f:/s/BHoM/EkRp-GxKlr1FkxpK7WtOMDkB95ttAkzAfw5WtvL-ZC-m4w?e=55xaF2
Changelog
Additional comments