Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging of events coming from Revit fixed #980

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Logging of events coming from Revit fixed #980

merged 1 commit into from
Feb 26, 2021

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Feb 25, 2021 •
edited
Loading

Issues addressed by this PR

Closes #979

Test files

On SharePoint - the content of the warnings on Pull does not matter, it is all about recording them at all.

Changelog

Additional comments

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Feb 25, 2021
@pawelbaran pawelbaran self-assigned this Feb 25, 2021
@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 25, 2021

@pawelbaran to confirm, check-code-compliance, check-documentation-compliance, check-project-compliance, check-branch-compliance, check-dataset-compliance, and, if applicable, check-copyright-compliance tasks are now queued.

adecler
adecler approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good on the code side.
Since we did the fix together, it would be good to have someone else to confirm it fixes to issue for them.

LMarkowski
LMarkowski approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@LMarkowski LMarkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say much about the code, but works pretty good for me. Checked also on some of my own files.

@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 26, 2021

@pawelbaran to confirm, check-code-compliance, check-documentation-compliance, check-project-compliance, check-branch-compliance, check-dataset-compliance, and, if applicable, check-copyright-compliance tasks are now queued.

@pawelbaran
Copy link
Member Author

/azp run Revit_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pawelbaran
Copy link
Member Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 26, 2021

@pawelbaran to confirm, check-core task is now queued.

@pawelbaran
Copy link
Member Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 26, 2021

@pawelbaran to confirm, check-installer task is now queued.

@pawelbaran pawelbaran merged commit 089a1a1 into master Feb 26, 2021
@pawelbaran pawelbaran deleted the Revit_Toolkit-#979-PassEventsToUI branch February 26, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LMarkowski LMarkowski LMarkowski approved these changes

@adecler adecler adecler approved these changes

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

@FraserGreenroyd FraserGreenroyd Awaiting requested review from FraserGreenroyd FraserGreenroyd is a code owner

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

Assignees

@pawelbaran pawelbaran

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Events stopped being passed from Revit_Toolkit to the UI
3 participants
@pawelbaran @adecler @LMarkowski