Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PreviousVersion attributes for previous milestones #952

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Remove PreviousVersion attributes for previous milestones #952

merged 1 commit into from
Jan 8, 2021

Conversation

BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Jan 8, 2021 •
edited by FraserGreenroyd
Loading

Closes #951

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jan 8, 2021
@bhombot-ci
Copy link

bhombot-ci bot commented Jan 8, 2021

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Robot_Toolkit

FraserGreenroyd
FraserGreenroyd approved these changes Jan 8, 2021
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed from a CI/CD perspective, will leave to discipline to merge.

@FraserGreenroyd
Copy link
Contributor

/azp run Revit_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 8, 2021

@FraserGreenroyd to confirm, check-code-compliance, check-documentation-compliance, check-project-compliance, check-branch-compliance, check-dataset-compliance, and, if applicable, check-copyright-compliance tasks are now queued.

pawelbaran
pawelbaran approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pawelbaran pawelbaran merged commit b2f0623 into master Jan 8, 2021
@pawelbaran pawelbaran deleted the BHoMBot-PreviousVersion41 branch January 8, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelbaran pawelbaran pawelbaran approved these changes

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

Assignees
No one assigned
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removal of PreviousVersion attributes
3 participants
@BHoMBot @FraserGreenroyd @pawelbaran