All type parameters stopped from being copied over to the BHoM objects on pull with type parameter mapping #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kThorsager
approved these changes
Jun 23, 2020
FraserGreenroyd
approved these changes
Jun 23, 2020
| { | ||
| if (parameter == null) | ||
| return null; | ||
|
|
||
| string name = parameter.Definition.Name; | ||
|
|
||
| IParameterLink parameterLink = parameterLinks.ParameterLink(parameter); |
There was a problem hiding this comment.
Can I check, is this anything to do with parameter links? 🤣
There was a problem hiding this comment.
Em, I think it is more about parameter links. 🐒
There was a problem hiding this comment.
I guess that makes some sense 🤔
|
/azp run Revit_Toolkit.CheckInstaller |
1 similar comment
|
/azp run Revit_Toolkit.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #755
Test file(s):
On SharePoint