Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copying of .addin file fixed #749

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Copying of .addin file fixed #749

merged 1 commit into from
Jun 10, 2020

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Jun 10, 2020 •
edited
Loading

Issues addressed by this PR

Closes #748

Test files

Not needed, actions to take:

  • go to %appdata%\Autodesk\Revit\Addins\20XX and delete BHoM_20XX.Addin file
  • go to C:\ProgramData\BHoM\Assemblies and delete Revit_Core_Adapter_20XX.dll and Revit_Core_Engine_20XX.dll files
  • Rebuild Revit_Toolkit on Debug20XX config and see if the files are back

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Jun 10, 2020
@pawelbaran pawelbaran self-assigned this Jun 10, 2020
kThorsager
kThorsager approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@kThorsager kThorsager left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, LGTM

alelom
alelom approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves the problem for me.

@pawelbaran
Copy link
Member Author

/azp run Revit_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pawelbaran pawelbaran merged commit 607e921 into master Jun 10, 2020
@pawelbaran pawelbaran deleted the Revit_Toolkit-#748-CopyAddinFile branch June 10, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kThorsager kThorsager kThorsager approved these changes

@alelom alelom alelom approved these changes

@FraserGreenroyd FraserGreenroyd Awaiting requested review from FraserGreenroyd FraserGreenroyd is a code owner

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

Assignees

@pawelbaran pawelbaran

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revit_Toolkit: PostBuild copying the .addin file does not work
3 participants
@pawelbaran @alelom @kThorsager