You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created convert methods to extract Revit Face to BHoM ISurface. The interface for this to happen is the same as the convert ICurve in RevitPullConfig, with an additional entry called pullSurfaces (maintained pullEdges).
Only PlanarSurface is implemented in this PR, other surface types to follow.
@FraserGreenroyd I believe it would be nice to have your review here because:
a) we need a green light in general 😆
b) this functionality might be really useful for BEnv - may be worth spreading the word
@FraserGreenroyd I believe it would be nice to have your review here because:
PR is still in WIP at the moment so I'm focusing on other tasks - if the PR is ready for review then I'm happy to give it a glance over but a proper test would have to wait till the weekend I'm afraid 😞
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tiagogrossi
added
the
status:WIP
FraserGreenroyd
deleted the
Revit_Toolkit-Issue454-Revit-faces-convert-to-BHoM-iSurfaces
branch
Issues addressed by this PR
Closes #454
Created convert methods to extract Revit
Faceto BHoMISurface. The interface for this to happen is the same as the convertICurveinRevitPullConfig, with an additional entry calledpullSurfaces(maintainedpullEdges).Only
PlanarSurfaceis implemented in this PR, other surface types to follow.Test files
Both GH and Revit files to test are here