-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revit profile generator introduced #1225
Conversation
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
…does not crash leaving the family document open
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested again successfully with 2 batches of 3000+ elements each 👍
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@pawelbaran to confirm, the following actions are now queued:
There are 20 requests in the queue ahead of you. |
NOTE: Depends on
BHoM/BHoM_Engine#2884
Issues addressed by this PR
Closes #1221
This feature loads default families on the fly and turns them into families and types correspondent to the pushed BHoM framing profiles.
Test files
On SharePoint, important notes:
@vietle-bh, I believe this is a nice piece of testing to be added to the Beta test procedures
Changelog
Additional comments
The structural properties of profiles are not copied over to the family types - this is a conscious decision to avoid introducing any errors. I think we need to make 200% sure we pass the right values to right properties before we do that, which would be good to checked by either @IsakNaslundBh, @peterjamesnugent or @JosefTaylor, probs better in a dedicated PR to stay focused.
@FraserGreenroyd, please note this will add ca. 8mb to the installer package - is that acceptable for you? I believe this is worth the benefit the feature brings.