Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revit profile generator introduced #1225

Merged
merged 17 commits into from
Jul 15, 2022

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Jul 13, 2022

NOTE: Depends on

BHoM/BHoM_Engine#2884

Issues addressed by this PR

Closes #1221

This feature loads default families on the fly and turns them into families and types correspondent to the pushed BHoM framing profiles.

Test files

On SharePoint, important notes:

  • Rhino document units need to be set to meters, distance tolerance to 1e-6 (important!)
  • when running the tests, I recommend doing ctrl+z in Revit after each test

@vietle-bh, I believe this is a nice piece of testing to be added to the Beta test procedures

Changelog

Additional comments

The structural properties of profiles are not copied over to the family types - this is a conscious decision to avoid introducing any errors. I think we need to make 200% sure we pass the right values to right properties before we do that, which would be good to checked by either @IsakNaslundBh, @peterjamesnugent or @JosefTaylor, probs better in a dedicated PR to stay focused.

@FraserGreenroyd, please note this will add ca. 8mb to the installer package - is that acceptable for you? I believe this is worth the benefit the feature brings.

@pawelbaran
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 14, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 2 requests in the queue ahead of you.

vietle-bh
vietle-bh previously approved these changes Jul 15, 2022
…does not crash leaving the family document open
@pawelbaran
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 15, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link
Contributor

@vietle-bh vietle-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested again successfully with 2 batches of 3000+ elements each 👍

@pawelbaran
Copy link
Member Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 15, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check ready-to-merge

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 15, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 20 requests in the queue ahead of you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate Revit profiles on the fly
3 participants