RevitTypeFragment introduced and BHoM converts fixed to pass the type information to the output object

[pawelbaran]

Issues addressed by this PR

Covers large portion of #1169

Test files

PR-specific test file on SharePoint.
Builders work openings can be tested using this script
BEnv openings can be test using PullBEnvModel from this folder

Changelog

• RevitTypeFragment introduced
• BHoM converts fixed to pass the type information to the output object.

Additional comments

Added @enarhi for reference - might be a good inspiration for fixing Facade converts.

Updates to output object:

• BH.oM.Architecture.BuildersWork.Opening - RevitTypeFragment is added along with Profile, which is not necessarily related to the element type (it is based on parameter values of the element itself)
  • BH.oM.Architecture.Elements.Room - RevitTypeFragment added because the object does not have a defining property
  • BH.oM.Environment.Elements.Opening - fixed to pass the parameters to OpeningConstruction
  • BH.oM.Environment.Elements.Space - RevitTypeFragment added because the object does not have a defining property
  • BH.oM.MEP.System.CableTray - RevitTypeFragment is added along with SectionProperty, which is not related to the element type (it is based on parameter values of the element itself)
  • BH.oM.MEP.System.Duct - RevitTypeFragment is added along with SectionProperty, which is not related to the element type (it is based on parameter values of the element itself)
  • BH.oM.MEP.System.Fittings.Fitting - RevitTypeFragment added because the object does not have a defining property
  • BH.oM.MEP.System.Pipe - RevitTypeFragment is added along with SectionProperty, which is not related to the element type (it is based on parameter values of the element itself)
  • BH.oM.MEP.System.Wire - RevitTypeFragment added because the object does not have a defining property
  • BH.oM.Physical.Elements.Door - convert fixed to create an empty Construction that represents the element type (and contains its parameters)
  • BH.oM.Physical.Elements.Window - convert fixed to create an empty Construction that represents the element type (and contains its parameters)

[pawelbaran]

@BHoMBot check compliance
@BHoMBot check null-handling

[bhombot-ci]

@pawelbaran to confirm, the following checks are now queued:

• code-compliance
• documentation-compliance
• project-compliance
• branch-compliance
• dataset-compliance
• copyright-compliance
• null-handling

[pawelbaran]

@BHoMBot check required

[bhombot-ci]

@pawelbaran to confirm, the following checks are now queued:

• code-compliance
• documentation-compliance
• project-compliance
• core
• null-handling
• serialisation
• versioning
• installer

[pawelbaran]

@BHoMBot check installer

[bhombot-ci]

@pawelbaran to confirm, the following checks are now queued:

• installer

[bhombot-ci]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. Force check: installer

[pawelbaran]

@BHoMBot check installer

[pawelbaran]

@BHoMBot check installer

[pawelbaran]

@BHoMBot you there

[bhombot-ci]

@pawelbaran sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

[pawelbaran]

@BHoMBot check installer

[bhombot-ci]

@pawelbaran to confirm, the following checks are now queued:

• installer

[michal-pekacki]

LGTM 👍

[pawelbaran]

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

[bhombot-ci]

@pawelbaran to confirm, the following checks are now queued:

• copyright-compliance
• dataset-compliance
• ready-to-merge