Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetRevitElementType and GetRevitTypeParameterValue methods added #1166

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Jan 26, 2022

Issues addressed by this PR

Closes #1165

Test files

On SharePoint.

Changelog

Additional comments

The methods yield correct results only for the BHoM types that have Revit element type information processed on FromRevit convert, i.e. major Physical types, Structural panels etc. Converts of many other types will need to be reviewed and potentially improved to convert the underlying element type and its params - a follow-up issue to be raised once this PR gets merged.

@pawelbaran pawelbaran added the type:feature New capability or enhancement label Jan 26, 2022
@pawelbaran pawelbaran self-assigned this Jan 26, 2022
@pawelbaran
Copy link
Member Author

@BHoMBot check compliance
@BHoMBot check null-handling
@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 26, 2022

@pawelbaran to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance
  • null-handling
  • core

There are 4 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check installer
@BHoMBot check serialisation
@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 26, 2022

@pawelbaran to confirm, the following checks are now queued:

  • installer
  • serialisation
  • versioning

There are 11 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 26, 2022

@pawelbaran to confirm, the following checks are now queued:

  • serialisation

Copy link
Member

@kayleighhoude kayleighhoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the way that this is working for objects that have established type parameter mapping (walls with constructions)
image
Will need work for space and duct objects, as their types have not yet been established in the convert (spaces) or the type parameters simply arent mapped across (ducts)
@pawelbaran please tag me in the associated forthcoming PRs on duct and space converts for types

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 28, 2022

@pawelbaran to confirm, the following checks are now queued:

  • ready-to-merge

@pawelbaran pawelbaran merged commit 99768d9 into main Jan 28, 2022
@pawelbaran pawelbaran deleted the Revit_Toolkit-#1165-GetElementTypeAndItsParameters branch January 28, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Revit element type and type parameter query
2 participants