-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GetRevitElementType and GetRevitTypeParameterValue methods added #1166
GetRevitElementType and GetRevitTypeParameterValue methods added #1166
Conversation
@pawelbaran to confirm, the following checks are now queued:
There are 4 requests in the queue ahead of you. |
@pawelbaran to confirm, the following checks are now queued:
There are 11 requests in the queue ahead of you. |
@BHoMBot check serialisation |
@pawelbaran to confirm, the following checks are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the way that this is working for objects that have established type parameter mapping (walls with constructions)
Will need work for space and duct objects, as their types have not yet been established in the convert (spaces) or the type parameters simply arent mapped across (ducts)
@pawelbaran please tag me in the associated forthcoming PRs on duct and space converts for types
@BHoMBot check ready-to-merge |
@pawelbaran to confirm, the following checks are now queued:
|
Issues addressed by this PR
Closes #1165
Test files
On SharePoint.
Changelog
Additional comments
The methods yield correct results only for the BHoM types that have Revit element type information processed on
FromRevit
convert, i.e. majorPhysical
types,Structural
panels etc. Converts of many other types will need to be reviewed and potentially improved to convert the underlying element type and its params - a follow-up issue to be raised once this PR gets merged.