-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calling Create method rather than constructor for MaterialComposition #1161
Calling Create method rather than constructor for MaterialComposition #1161
Conversation
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh just to let you know, I have provided a |
@BHoMBot check project-compliance |
@IsakNaslundBh to confirm, the following checks are now queued:
There are 25 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pawelbaran to confirm, the following checks are now queued:
There are 41 requests in the queue ahead of you. |
@IsakNaslundBh just to let you know, I have provided a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed in conjunction with the PRs on oM and Engine and matches with expectations. Review from @pawelbaran also so this is good to go to main
.
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following checks are now queued:
|
NOTE: Depends on
Does not depend on for compilation, but done in alignment with BHoM/BHoM#1341 and BHoM/BHoM_Engine#2733.
Checks done in constructor migrated to engine Create method.
Issues addressed by this PR
Calling Create method rather than constructor straight away to ensure checks and potential error messages are raised appropriately
Test files
Changelog
Additional comments