Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling Create method rather than constructor for MaterialComposition #1161

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Jan 14, 2022

NOTE: Depends on

Does not depend on for compilation, but done in alignment with BHoM/BHoM#1341 and BHoM/BHoM_Engine#2733.
Checks done in constructor migrated to engine Create method.

Issues addressed by this PR

Calling Create method rather than constructor straight away to ensure checks and potential error messages are raised appropriately

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh requested review from pawelbaran and removed request for pawelbaran January 14, 2022 15:53
@IsakNaslundBh IsakNaslundBh changed the title Calling Create method rather than constructor Calling Create method rather than constructor for MaterialComposition Jan 14, 2022
@IsakNaslundBh IsakNaslundBh self-assigned this Jan 14, 2022
@IsakNaslundBh IsakNaslundBh added the type:compliance Non-conforming to code guidelines label Jan 14, 2022
@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • project-compliance

There are 25 requests in the queue ahead of you.

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pawelbaran
Copy link
Member

@BHoMBot check compliance
@BHoMBot check null-handling
@BHoMBot check core
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@pawelbaran to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance
  • null-handling
  • core
  • serialisation

There are 41 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in conjunction with the PRs on oM and Engine and matches with expectations. Review from @pawelbaran also so this is good to go to main.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 14, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 889a500 into main Jan 14, 2022
@FraserGreenroyd FraserGreenroyd deleted the Pysical_oM-1340-RemoveChecksFromMaterialCompositionConstructor branch January 14, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants