Element type query centralised and made more logical

[pawelbaran]

Issues addressed by this PR

Closes #1146

Test files

On SharePoint.

Changelog

• Revit element type search centralised for creation and update of the elements based on the BHoM objects
• informative warnings added to explain to the user what is the source of the element type information for given convert (BHoM object name vs name of its defining property like Construction)
• Query.ElementType stopped from modifying the queried Revit element types

Additional comments

The problem proved to be much more complex than originally stated #1146. There were 3 parallel challenges to deal with:

• element type query being different on creation and update of the Revit elements based on BHoM objects
• not enough feedback on how what is happening on type update
• element type query being able to modify the queried type

First two were rather straightforward to capture and fix, just a matter of pulling the strings together. The 3rd one, however, was a bit more tricky. Until now, when Query.ElementType was called on physical Wall, Beam etc., ToRevitElementType method was called from within. This resulted in an attempt to convert and overwrite the parameters of the existing type (if found) instead of simply querying it. This, I believe, is fundamentally wrong, so this has been changed to Query.ElementType only querying the element type, but never modifying it.

The above is a breaking change, but I believe it is a step in the right direction, plus it is likely to be left unnoticed by the users. The only scenario affected by the change is a Push of an object with its defining property (e.g. Construction) having modified Revit parameter values (not properties) using SetRevitParameter method. Now, after the change, Push of elements affects the elements, while modification of element types can be achieved by pushing the element types themselves.

Sorry for the non-Revit users trying to understand the above 🙈

[pawelbaran]

@BHoMBot check core

[bhombot-ci]

@pawelbaran to confirm, the following checks are now queued:

• core

There are 4 requests in the queue ahead of you.

[pawelbaran]

@BHoMBot check compliance
@BHoMBot check null-handling

[bhombot-ci]

@pawelbaran to confirm, the following checks are now queued:

• code-compliance
• documentation-compliance
• project-compliance
• branch-compliance
• dataset-compliance
• copyright-compliance
• null-handling

There are 4 requests in the queue ahead of you.

[pawelbaran]

@BHoMBot check compliance
@BHoMBot check null-handling

[bhombot-ci]

@pawelbaran to confirm, the following checks are now queued:

• code-compliance
• documentation-compliance
• project-compliance
• branch-compliance
• dataset-compliance
• copyright-compliance
• null-handling

There are 18 requests in the queue ahead of you.

[pawelbaran]

@BHoMBot check core
@BHoMBot check installer
@BHoMBot check serialisation
@BHoMBot check versioning

[bhombot-ci]

@pawelbaran to confirm, the following checks are now queued:

• core
• installer
• serialisation
• versioning

There are 19 requests in the queue ahead of you.

[pawelbaran]

@BHoMBot check compliance
@BHoMBot check core
@BHoMBot check null-handling

[bhombot-ci]

@pawelbaran to confirm, the following checks are now queued:

• code-compliance
• documentation-compliance
• project-compliance
• branch-compliance
• dataset-compliance
• copyright-compliance
• core
• null-handling

There are 31 requests in the queue ahead of you.

[pawelbaran]

@BHoMBot check installer
@BHoMBot check serialisation
@BHoMBot check versioning

[bhombot-ci]

@pawelbaran to confirm, the following checks are now queued:

• installer
• serialisation
• versioning

There are 62 requests in the queue ahead of you.

[michal-pekacki]

Tested on different Revit versions and LGTM! 👍

[pawelbaran]

@BHoMBot check required

[bhombot-ci]

@pawelbaran to confirm, the following checks are now queued:

• code-compliance
• documentation-compliance
• project-compliance
• core
• null-handling
• serialisation
• versioning
• installer

[michal-pekacki]

LGTM 👍

[pawelbaran]

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

[bhombot-ci]

@pawelbaran to confirm, the following checks are now queued:

• copyright-compliance
• dataset-compliance
• ready-to-merge

There are 15 requests in the queue ahead of you.