BH.oM.Physical.Elements.ISurfaces stopped from failing to transform when their Location is not PlanarSurface

[pawelbaran]

NOTE: Depends on

BHoM/BHoM_Engine#2416

Issues addressed by this PR

Closes #1001

Test files

• problem-specific files: BH.oM.Physical.Elements.ISurfaces fail to transform when their Location is not PlanarSurface #1001-TransformPolySurfaceBug.gh from here, to be tested with FromLink_PullPanelLocation.rvt from here
• general test files: FromLink_PullWallFloorRoofLocation.gh with FromLink_PullPanelLocation.rvt from here

Changelog

Additional comments

The issue mentioned in the header of this PR is 99% covered by BHoM/BHoM_Engine#2416. This PR is building on top of it, by eliminating the edge case NullReferenceException that may occur, totalling with (hopefully) fairly robust behaviour.

[LMarkowski]

Generally looks good to me. All panels are being pulled correctly.

One strange thing noticed in the test file. Four panels ale lost by grasshopper's Region Difference component (highlighted in green), despite looking good on pull.

It shouldn't block this PR but might be worth investigating.

[bhombot-ci]

@pawelbaran just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine

[pawelbaran]

/azp run Revit_Toolkit.CheckInstaller

[pawelbaran]

@BHoMBot check installer

[bhombot-ci]

@pawelbaran to confirm, check-installer task is now queued.

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[pawelbaran]

@BHoMBot check core

[bhombot-ci]

@pawelbaran to confirm, check-core task is now queued.

[pawelbaran]

@BHoMBot check compliance

[bhombot-ci]

@pawelbaran to confirm, check-code-compliance, check-documentation-compliance, check-project-compliance, check-branch-compliance, check-dataset-compliance, and, if applicable, check-copyright-compliance tasks are now queued.

[bhombot-ci]

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine