Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced calls to Query.Clone() and Query.IClone() with calls to BH.Engine.Base.DeepClone() #188

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

alelom
Copy link
Member

@alelom alelom commented Jul 30, 2021

NOTE: Depends on

BHoM/BHoM_Engine#2585

Issues addressed by this PR

Closes #187

Test files

Changelog

Additional comments

@alelom alelom requested a review from FraserGreenroyd July 30, 2021 11:16
@alelom alelom self-assigned this Jul 30, 2021
@alelom alelom added the type:compliance Non-conforming to code guidelines label Jul 30, 2021
@bhombot-ci
Copy link

bhombot-ci bot commented Jul 30, 2021

@alelom just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @alelom on BHoM_Engine

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Jul 30, 2021

@alelom just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @alelom on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 30, 2021

@alelom just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @alelom on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 30, 2021

@alelom just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Jul 30, 2021

@alelom just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required
@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 30, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning
  • copyright-compliance
  • dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 30, 2021

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 30, 2021

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed in line with this PR

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 30, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 4deb7e1 into master Jul 30, 2021
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-#2576-RemoveGeometryClone branch July 30, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace calls to Query.Clone() and Query.IClone() with calls to BH.Engine.Base.DeepClone()
2 participants