Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Geometric Unit conversions to comply with SI standard BHoM units #138

Merged
merged 8 commits into from
May 1, 2020

Conversation

enarhi
Copy link
Member

@enarhi enarhi commented Apr 30, 2020

Issues addressed by this PR

Closes #21

This PR handles unit conversions such that bhom elements pulled from RAM are automatically converted to SI, and bhom elements sent to RAM are automatically converted to RAM Database default units (Inches).

This PR DOES NOT handle conversions of force units. It only handles geometric conversions, with force conversions to follow.

Test files

BHoM Test Script - Read And Create - RAM.zip

@enarhi enarhi added the type:feature New capability or enhancement label Apr 30, 2020
@enarhi enarhi self-assigned this Apr 30, 2020
JosefTaylor
JosefTaylor previously approved these changes May 1, 2020
Copy link
Contributor

@JosefTaylor JosefTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good!

@JosefTaylor
Copy link
Contributor

/azp run RAM_Toolkit.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@enarhi
Copy link
Member Author

enarhi commented May 1, 2020

/azp run RAM_Toolkit.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@enarhi
Copy link
Member Author

enarhi commented May 1, 2020

/azp run RAM_Toolkit.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@JosefTaylor JosefTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still good

@enarhi enarhi merged commit 390a7fc into master May 1, 2020
@enarhi enarhi deleted the RAM_Toolkit-#21-UnitsHandling branch May 1, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RAM_Toolkit: scale geometry to meters from inches
2 participants