Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHoM managed Python virtualenvs #85

Merged

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Aug 15, 2022

Issues addressed by this PR

Closes #83
Closes #81
Closes #79
Closes #62
Closes #46

Handling of Python environments via BHoM rationalised around a base "full" environment, and virtualenvs for any toolkit/project-specific environment that can be pre-defined with custom codebases via a referenced local-package added upon installation.

Test files

83.zip

Changelog

Additional comments

@tg359 tg359 added severity:critical No workaround exists. Essential to continue size:L Measured in days status:do-not-merge For instance, test PR, requires further discussion, or dependant PRs not ready for merge type:feature New capability or enhancement priority:high High impact, high user value, driven by live project needs labels Aug 15, 2022
@tg359 tg359 self-assigned this Aug 15, 2022
@tg359
Copy link
Contributor Author

tg359 commented Aug 15, 2022

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 15, 2022

@tg359 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 1 requests in the queue ahead of you.

@tg359
Copy link
Contributor Author

tg359 commented Sep 9, 2022

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2022

@tg359 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 9 requests in the queue ahead of you.

@tg359
Copy link
Contributor Author

tg359 commented Sep 9, 2022

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2022

@tg359 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 52 requests in the queue ahead of you.

@tg359
Copy link
Contributor Author

tg359 commented Sep 9, 2022

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2022

@tg359 to confirm, the following actions are now queued:

  • check versioning

There are 7 requests in the queue ahead of you.

@BHoM BHoM deleted a comment from bhombot-ci bot Sep 9, 2022
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core

There are 18 requests in the queue ahead of you.

@tg359
Copy link
Contributor Author

tg359 commented Sep 9, 2022

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2022

@tg359 to confirm, the following actions are now queued:

  • check versioning

There are 8 requests in the queue ahead of you.

@tg359
Copy link
Contributor Author

tg359 commented Sep 9, 2022

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2022

@tg359 to confirm, the following actions are now queued:

  • check versioning

There are 38 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2022

@tg359 just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on LadybugTools_Toolkit

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 5 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check null-handling
@BHoMBot check core
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check null-handling
  • check core
  • check serialisation

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on @alelom review as commits since then have been versioning and compliance.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 54 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd removed the status:do-not-merge For instance, test PR, requires further discussion, or dependant PRs not ready for merge label Sep 9, 2022
@FraserGreenroyd FraserGreenroyd merged commit 631ddf8 into main Sep 9, 2022
@FraserGreenroyd FraserGreenroyd deleted the Python_Toolkit-#83-SimplificationAndExternalEnvironments branch September 9, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high High impact, high user value, driven by live project needs severity:critical No workaround exists. Essential to continue size:L Measured in days type:feature New capability or enhancement
Projects
None yet
3 participants