Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenStreetMap_Engine: Update ElementContainer support HTTP Adapter for requests #27

Merged
merged 1 commit into from
Apr 16, 2020
Merged

OpenStreetMap_Engine: Update ElementContainer support HTTP Adapter for requests #27

merged 1 commit into from
Apr 16, 2020

Conversation

rolyhudson
Copy link
Contributor

@rolyhudson rolyhudson commented Apr 16, 2020 •
edited
Loading

Issues addressed by this PR

Closes #22 and #6
ElementContainer now stores OSM relations and is generated from the results of pull request with HTTP_Adapter

Test files

In repo examples folder example *.gh files updated to use HTTP Adapter.

@rolyhudson rolyhudson requested a review from BHoMBot April 16, 2020 09:42
@rolyhudson rolyhudson self-assigned this Apr 16, 2020
@rolyhudson rolyhudson added this to the BHoM 3.2 β MVP milestone Apr 16, 2020
@rolyhudson rolyhudson added size:S Measured in minutes type:compliance type:feature New capability or enhancement labels Apr 16, 2020
FraserGreenroyd
FraserGreenroyd approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run the example files and that seems to work ok.

I'd be remiss if I didn't comment on the lack of white space around the methods but otherwise everything looks ok to me 😄

@rolyhudson
Copy link
Contributor Author

🤣 thanks @FraserGreenroyd

@rolyhudson rolyhudson merged commit 966dc62 into master Apr 16, 2020
@rolyhudson rolyhudson deleted the OpenStreetMap_Engine_ElementContainer branch April 16, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@BHoMBot BHoMBot Awaiting requested review from BHoMBot

Assignees

@rolyhudson rolyhudson

Labels
size:S Measured in minutes type:compliance type:feature New capability or enhancement
Projects
None yet
Milestone
BHoM 3.2 β MVP
Development

Successfully merging this pull request may close these issues.

Generate ElementContainer from result of HTTP Pull
2 participants
@rolyhudson @FraserGreenroyd