Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Compliance issue for CSProj files #108

Merged
merged 1 commit into from
May 8, 2020
Merged

Fix Compliance issue for CSProj files #108

merged 1 commit into from
May 8, 2020

Conversation

adecler
Copy link
Member

@adecler adecler commented May 8, 2020

Issues addressed by this PR

Closes #106
Closes #107

This actually fixes more then covered by the two issues above:

  • Some BHoM dlls like Reflection_oM and Reflection_Engine were not mentioned in the issue
  • The Mongo_Engine needed fixing too

@adecler adecler requested review from FraserGreenroyd and alelom and removed request for FraserGreenroyd May 8, 2020 03:56
@adecler adecler self-assigned this May 8, 2020
@adecler adecler added the type:compliance Non-conforming to code guidelines label May 8, 2020
@adecler adecler added this to the BHoM 3.2 β MVP milestone May 8, 2020
@IsakNaslundBh
Copy link
Contributor

/azp run Mongo_Toolkit.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@adecler adecler requested a review from IsakNaslundBh May 8, 2020 10:19
FraserGreenroyd
FraserGreenroyd approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compliance is happy and changes look ok to me. Have only done a code review but can do a full review if desired.

@adecler adecler merged commit 5537b3e into master May 8, 2020
@adecler adecler deleted the Mongo_Toolkit-#106-FixCsProjCompliance branch May 8, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@alelom alelom Awaiting requested review from alelom

@IsakNaslundBh IsakNaslundBh Awaiting requested review from IsakNaslundBh

Assignees

@adecler adecler

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
BHoM 3.2 β MVP
Development

Successfully merging this pull request may close these issues.

Compliance issue for CSProj files Compliance issue for CSProj files
3 participants
@adecler @IsakNaslundBh @FraserGreenroyd