Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.1 Deployment #374

Merged
merged 18 commits into from
Mar 27, 2024
Merged

7.1 Deployment #374

merged 18 commits into from
Mar 27, 2024

Conversation

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Mar 11, 2024
@FraserGreenroyd FraserGreenroyd self-requested a review March 11, 2024 10:41
@KalleEdstroem KalleEdstroem self-requested a review March 15, 2024 16:51
KalleEdstroem
KalleEdstroem previously approved these changes Mar 15, 2024
Copy link
Contributor

@KalleEdstroem KalleEdstroem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with BHoM_7.1.240312.beta.0
Checked with BHoM_7.1.240315.beta.0 after bug fix merged.

Test was carried out following test procedures.

Happy to approve.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

Copy link
Author

bhombot-ci bot commented Mar 19, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 89 requests in the queue ahead of you.

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be approved based on @KalleEdstroem's testing. My changes were purely compliance and made no changes to the functionality of the toolkit.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

Copy link
Author

bhombot-ci bot commented Mar 26, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 59 requests in the queue ahead of you.

Copy link
Author

bhombot-ci bot commented Mar 26, 2024

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on SQL_Toolkit

1 similar comment
Copy link
Author

bhombot-ci bot commented Mar 26, 2024

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on SQL_Toolkit

Copy link
Author

bhombot-ci bot commented Mar 27, 2024

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

Copy link
Author

bhombot-ci bot commented Mar 27, 2024

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on SQL_Toolkit

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: null-handling, serialisation, dataset-compliance, unit-tests

Copy link
Author

bhombot-ci bot commented Mar 27, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs have been reviewed by DevOps and bot checks and are suitable for deployment for updating copyright headers to 2024. Approving for merge.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core

Copy link
Author

bhombot-ci bot commented Mar 27, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs have been reviewed by DevOps and are suitable for the deployment of develop to the 7.1 beta. Approving for merge.

Copy link
Author

bhombot-ci bot commented Mar 27, 2024

@bhombot-ci[bot] just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd FraserGreenroyd merged commit 08a3537 into main Mar 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants