Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with changes in Structure_Engine #324

Merged

Conversation

IsakNaslundBh
Copy link
Contributor

NOTE: Depends on

Done is support of, but compiles without BHoM/BHoM_Engine#2738

Issues addressed by this PR

Align with removed methods from Structure_Engine

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Jan 24, 2022
@IsakNaslundBh IsakNaslundBh self-assigned this Jan 24, 2022
@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2022

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2022

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check null-handling
@BHoMBot check project-compliance
@BHoMBot check documentation-compliance
@BHoMBot check serialisation
@BHoMBot check core
@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 26, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • null-handling
  • project-compliance
  • documentation-compliance
  • serialisation
  • core
  • copyright-compliance

There are 23 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 26, 2022

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 4050f9f into main Jan 26, 2022
@FraserGreenroyd FraserGreenroyd deleted the Structure_Engine-#2736-CleanUpToBeRemovedMethod branch January 26, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants