Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where *VERSION was not correctly set #287

Merged
merged 3 commits into from
Jan 21, 2021
Merged

Fix bug where *VERSION was not correctly set #287

merged 3 commits into from
Jan 21, 2021

Conversation

peterjamesnugent
Copy link
Member

Issues addressed by this PR

Closes #251
Closes #286

  • Changed when a default m_midasCivilVersion was set
  • Made m_midasCivilVersion public so it is viewable from exploding the Adapter

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/Archive/MidasCivil_Toolkit/MidasCivil_Toolkit-%23286?csf=1&web=1&e=2xc3Iy

Changelog

  • Fixed a bug the m_midasCivilVersion was defaulting to 8.8.1 despite using an override within the adapter

@peterjamesnugent peterjamesnugent added severity:critical No workaround exists. Essential to continue size:S Measured in minutes type:bug Error or unexpected behaviour labels Jan 19, 2021
@peterjamesnugent peterjamesnugent added this to the BHoM 4.1 β RC milestone Jan 19, 2021
@peterjamesnugent peterjamesnugent self-assigned this Jan 19, 2021
@peterjamesnugent
Copy link
Member Author

@BHoMBot check all

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 19, 2021

@peterjamesnugent to confirm, check-code-compliance, check-documentation-compliance, check-project-compliance, check-branch-compliance, check-dataset-compliance, if applicable check-copyright-compliance, check-unit-tests, check-core, and check-installer tasks are now queued.

StephennipBH
StephennipBH requested changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@StephennipBH StephennipBH left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue #286 has been resolved. All items have been tested. There is an issue with the 'SaveAs' command when the midas file is not a blank file. Please see below for the error message.
image

@peterjamesnugent
Copy link
Member Author

@BHoMBot check all

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 21, 2021

@peterjamesnugent to confirm, check-code-compliance, check-documentation-compliance, check-project-compliance, check-branch-compliance, check-dataset-compliance, if applicable check-copyright-compliance, check-unit-tests, check-core, and check-installer tasks are now queued.

@StephennipBH StephennipBH self-requested a review January 21, 2021 17:03
StephennipBH
StephennipBH approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@StephennipBH StephennipBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug in regards to *VERSION is fixed. The 'SaveAs' issue will be raised in a new issue

Changes Approved.

@peterjamesnugent
Copy link
Member Author

/azp run MidasCivil_Toolkit.CheckPR

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@peterjamesnugent
Copy link
Member Author

/azp run MidasCivil_Toolkit.PR

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@FraserGreenroyd FraserGreenroyd merged commit 05f98ac into master Jan 21, 2021
@FraserGreenroyd FraserGreenroyd deleted the MidasCivil_Toolkit-251-286-SwitchStatementsAndVersionBug branch January 21, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephennipBH StephennipBH StephennipBH approved these changes

Assignees

@peterjamesnugent peterjamesnugent

Labels
severity:critical No workaround exists. Essential to continue size:S Measured in minutes type:bug Error or unexpected behaviour
Projects
None yet
Milestone
BHoM 4.1 β RC
Development

Successfully merging this pull request may close these issues.

Midas Version Input Bug Verify any changes to the parsing of MCT files in MidasCivil 2020 v3.2
3 participants
@peterjamesnugent @StephennipBH @FraserGreenroyd