Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various bug fixes for reading from MidasCivil #226

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Jun 18, 2020

Issues addressed by this PR

Closes #225
Closes #227
Closes #228
Closes #229

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/EtPgDV8xjf5Dtu5THK-BpJ8BxZe7XfRLQ1nXUlGHHlY_Wg?e=BBh5sm

Changelog

  • Added string.Trim() to strings being read from MCT files to ensure section names are correct
  • Fixed bug where reading ISection from MidasCivil used a deprecated method and produced inconceivable sections
  • Fixed bug where BarPointLoad, BarUniformlyDistributedLoadandBarVaryingDistributedLoadreferenced the wrong index forName` properties
  • Fixed bug where GravityLoad referenced the wrong indexes
  • Removed official support for MidasCivil, the majority of functionality should still work but we are unable to test MidasCivil 2018 in particular GravityLoad which was causing issues for Midas Civil 2019 onwards

Additional comments

Three tests:

  1. Push to non existing - the Adapter should recognise Section1, Section2 etc. already exist and not push
  2. Read a model, and then combine the files and load it in to MidasCivil. This will confirm that the trimming of properties has not affected any functionality.
  3. Added a third script to test pushing elements, loads and pulling loads

@peterjamesnugent peterjamesnugent added severity:critical No workaround exists. Essential to continue size:S Measured in minutes type:bug Error or unexpected behaviour labels Jun 18, 2020
@peterjamesnugent peterjamesnugent added this to the BHoM 3.2 β RC milestone Jun 18, 2020
@peterjamesnugent peterjamesnugent self-assigned this Jun 18, 2020
@peterjamesnugent
Copy link
Member Author

/azp run MidasCivil_Toolkit.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@peterjamesnugent
Copy link
Member Author

/azp run MidasCivil_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@StephennipBH StephennipBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed the file according to the steps but Midas is not able to read the .mct files.

@peterjamesnugent peterjamesnugent changed the title Added trim method to strings that are read from .mct files Various bug fixes for reading from MidasCivil Jun 20, 2020
@peterjamesnugent
Copy link
Member Author

/azp run MidasCivil_Toolkit.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@peterjamesnugent
Copy link
Member Author

/azp run MidasCivil_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@StephennipBH StephennipBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work as intended. Changes approved.

@peterjamesnugent peterjamesnugent merged commit e333353 into master Jun 22, 2020
@peterjamesnugent peterjamesnugent deleted the MidasCivil_Toolkit-225-TrimPropertyNamesWhenReadingMCTFile branch June 22, 2020 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:critical No workaround exists. Essential to continue size:S Measured in minutes type:bug Error or unexpected behaviour
Projects
None yet
2 participants