-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various bug fixes for reading from MidasCivil #226
Various bug fixes for reading from MidasCivil #226
Conversation
/azp run MidasCivil_Toolkit.CheckCompliance |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run MidasCivil_Toolkit.CheckInstaller |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have pushed the file according to the steps but Midas is not able to read the .mct files.
/azp run MidasCivil_Toolkit.CheckCompliance |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run MidasCivil_Toolkit.CheckInstaller |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes work as intended. Changes approved.
Issues addressed by this PR
Closes #225
Closes #227
Closes #228
Closes #229
Test files
https://burohappold.sharepoint.com/:f:/s/BHoM/EtPgDV8xjf5Dtu5THK-BpJ8BxZe7XfRLQ1nXUlGHHlY_Wg?e=BBh5sm
Changelog
ISection
from MidasCivil used a deprecated method and produced inconceivable sectionsBarPointLoad
, BarUniformlyDistributedLoadand
BarVaryingDistributedLoadreferenced the wrong index for
Name` propertiesGravityLoad
referenced the wrong indexesAdditional comments
Three tests: